Closed Bug 1361880 Opened 4 years ago Closed 4 years ago

Dynamic toolbar does not check if the drag threshold has been reached before hiding or showing at end of touch

Categories

(Firefox for Android Graveyard :: Toolbar, defect, P3)

55 Branch
All
Android
defect

Tracking

(firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

RESOLVED FIXED
Firefox 55
Tracking Status
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: rbarker, Assigned: rbarker)

References

Details

(Keywords: regression)

Attachments

(1 file)

This appears to be a regression caused by the fix for Bug 1358774.
Assignee: nobody → rbarker
Depends on: 1358774
Blocks: 1358774
No longer depends on: 1358774
Keywords: regression
OS: Unspecified → Android
Priority: -- → P3
Hardware: Unspecified → All
Summary: Dynamic toolbar does not check if the drag threshold has been reached before hiding or showing at end of touch` → Dynamic toolbar does not check if the drag threshold has been reached before hiding or showing at end of touch
Version: unspecified → 55 Branch
Comment on attachment 8864336 [details]
Bug 1361880 - Prevent toolbar from animating when drag threshold has not been reached

https://reviewboard.mozilla.org/r/135970/#review139706

::: gfx/layers/apz/src/AndroidDynamicToolbarAnimator.cpp:591
(Diff revision 1)
>    if (cancelTouchTracking) {
>      return;
>    }
>  
> +  // The drag threshold has not been reach and the toolbar is either completely visible or completely hidden.
> +  if (!dragThresholdReached && ((mControllerToolbarHeight == mControllerMaxToolbarHeight) || (mControllerToolbarHeight == 0))) {

I'm not seeing a variable named "dragThresholdReached" being declared anywhere, so this patch shouldn't even build. Am I missing something?
Comment on attachment 8864336 [details]
Bug 1361880 - Prevent toolbar from animating when drag threshold has not been reached

https://reviewboard.mozilla.org/r/135970/#review139714

::: gfx/layers/apz/src/AndroidDynamicToolbarAnimator.cpp:591
(Diff revision 1)
>    if (cancelTouchTracking) {
>      return;
>    }
>  
> +  // The drag threshold has not been reach and the toolbar is either completely visible or completely hidden.
> +  if (!dragThresholdReached && ((mControllerToolbarHeight == mControllerMaxToolbarHeight) || (mControllerToolbarHeight == 0))) {

Sorry, I have five patches from five bugs all depending on each other and it sneaked into a later patch. Fixed and pushed new patch.
Comment on attachment 8864336 [details]
Bug 1361880 - Prevent toolbar from animating when drag threshold has not been reached

https://reviewboard.mozilla.org/r/135970/#review139712

Thanks, that makes more sense :)
Attachment #8864336 - Flags: review?(botond) → review+
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13fc94c53f3f
Prevent toolbar from animating when drag threshold has not been reached r=botond
https://hg.mozilla.org/mozilla-central/rev/13fc94c53f3f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.