1361880 - Dynamic toolbar does not check if the drag threshold has been reached before hiding or showing at end of touch

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect, P3)

Description

[Randall Barker [:rbarker]]

This appears to be a regression caused by the fix for Bug 1358774.

Comment 1

[Randall Barker [:rbarker]]

Attachment: Bug 1361880 - Prevent toolbar from animating when drag threshold has not been reached

Review commit: https://reviewboard.mozilla.org/r/135970/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135970/

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8864336 [details]
Bug 1361880 - Prevent toolbar from animating when drag threshold has not been reached

https://reviewboard.mozilla.org/r/135970/#review139706

::: gfx/layers/apz/src/AndroidDynamicToolbarAnimator.cpp:591
(Diff revision 1)
>    if (cancelTouchTracking) {
>      return;
>    }
>  
> +  // The drag threshold has not been reach and the toolbar is either completely visible or completely hidden.
> +  if (!dragThresholdReached && ((mControllerToolbarHeight == mControllerMaxToolbarHeight) || (mControllerToolbarHeight == 0))) {

I'm not seeing a variable named "dragThresholdReached" being declared anywhere, so this patch shouldn't even build. Am I missing something?

Comment 3

[Randall Barker [:rbarker]]

Comment on attachment 8864336 [details]
Bug 1361880 - Prevent toolbar from animating when drag threshold has not been reached

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/135970/diff/1-2/

Comment 4

[Randall Barker [:rbarker]]

Comment on attachment 8864336 [details]
Bug 1361880 - Prevent toolbar from animating when drag threshold has not been reached

https://reviewboard.mozilla.org/r/135970/#review139714

::: gfx/layers/apz/src/AndroidDynamicToolbarAnimator.cpp:591
(Diff revision 1)
>    if (cancelTouchTracking) {
>      return;
>    }
>  
> +  // The drag threshold has not been reach and the toolbar is either completely visible or completely hidden.
> +  if (!dragThresholdReached && ((mControllerToolbarHeight == mControllerMaxToolbarHeight) || (mControllerToolbarHeight == 0))) {

Sorry, I have five patches from five bugs all depending on each other and it sneaked into a later patch. Fixed and pushed new patch.

Comment 5

[Botond Ballo [:botond]]

Comment on attachment 8864336 [details]
Bug 1361880 - Prevent toolbar from animating when drag threshold has not been reached

https://reviewboard.mozilla.org/r/135970/#review139712

Thanks, that makes more sense :)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/13fc94c53f3f
Prevent toolbar from animating when drag threshold has not been reached r=botond

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/13fc94c53f3f