Closed Bug 1361949 Opened 3 years ago Closed 3 years ago

[Build bustage] Add a missing 'using namespace' to widget/windows/nsDragService.cpp

Categories

(Core :: Printing: Output, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: fatseng, Assigned: fatseng)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → fatseng
Status: NEW → ASSIGNED
Comment on attachment 8864401 [details]
Bug 1361949 - Add missing 'using namespace::widget' to widget/windows/nsDragService.cpp

Add a missing 'using namespace::widget' to fix build break.

2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(373): error C2065: 'ModifierKeyState': undeclared identifier
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(373): error C2146: syntax error: missing ';' before identifier 'modifierKeyState'
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(373): error C2065: 'modifierKeyState': undeclared identifier
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(374): error C2065: 'modifierKeyState': undeclared identifier
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(374): error C2228: left of '.GetModifiers' must have class/struct/union
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(374): note: type is 'unknown-type'
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(374): error C2660: 'nsDragService::EndDragSession': function does not take 1 arguments
2:20.19 c:/mozilla-source/gecko-0215/config/rules.mk:1059: recipe for target 'Unified_cpp_widget_windows2.obj' failed
2:20.19 mozmake.EXE[6]: *** [Unified_cpp_widget_windows2.obj] Error 2
Attachment #8864401 - Flags: review?(jwatt)
Comment on attachment 8864401 [details]
Bug 1361949 - Add missing 'using namespace::widget' to widget/windows/nsDragService.cpp

https://reviewboard.mozilla.org/r/136092/#review139128

::: commit-message-971dc:1
(Diff revision 2)
> +Bug 1361949 - Add a missing 'using namespace::widget' to widget/windows/nsDragService.cpp

"Add missing 'using namespace mozilla::widget' to widget/windows/nsDragService.cpp"
Attachment #8864401 - Flags: review?(jwatt) → review+
Pushed by fatseng@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4ec64c93ac17
Add missing 'using namespace::widget' to widget/windows/nsDragService.cpp r=jwatt
https://hg.mozilla.org/mozilla-central/rev/4ec64c93ac17
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.