1361949 - [Build bustage] Add a missing 'using namespace' to widget/windows/nsDragService.cpp

Status: RESOLVED FIXED

(Core :: Printing: Output, enhancement)

Comment 1

[Farmer Tseng[:fatseng](inactive)]

Attachment: Bug 1361949 - Add missing 'using namespace::widget' to widget/windows/nsDragService.cpp

Because ModifierKeyState is in the 'mozilla::widget' namespace, this file uses
it without qualification.

Review commit: https://reviewboard.mozilla.org/r/136092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136092/

Comment 2

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8864401 [details]
Bug 1361949 - Add missing 'using namespace::widget' to widget/windows/nsDragService.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136092/diff/1-2/

Comment 3

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8864401 [details]
Bug 1361949 - Add missing 'using namespace::widget' to widget/windows/nsDragService.cpp

Add a missing 'using namespace::widget' to fix build break.

2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(373): error C2065: 'ModifierKeyState': undeclared identifier
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(373): error C2146: syntax error: missing ';' before identifier 'modifierKeyState'
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(373): error C2065: 'modifierKeyState': undeclared identifier
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(374): error C2065: 'modifierKeyState': undeclared identifier
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(374): error C2228: left of '.GetModifiers' must have class/struct/union
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(374): note: type is 'unknown-type'
2:20.19 c:/mozilla-source/gecko-0215/widget/windows/nsDragService.cpp(374): error C2660: 'nsDragService::EndDragSession': function does not take 1 arguments
2:20.19 c:/mozilla-source/gecko-0215/config/rules.mk:1059: recipe for target 'Unified_cpp_widget_windows2.obj' failed
2:20.19 mozmake.EXE[6]: *** [Unified_cpp_widget_windows2.obj] Error 2

Comment 4

[Jonathan Watt [:jwatt]]

Comment on attachment 8864401 [details]
Bug 1361949 - Add missing 'using namespace::widget' to widget/windows/nsDragService.cpp

https://reviewboard.mozilla.org/r/136092/#review139128

::: commit-message-971dc:1
(Diff revision 2)
> +Bug 1361949 - Add a missing 'using namespace::widget' to widget/windows/nsDragService.cpp

"Add missing 'using namespace mozilla::widget' to widget/windows/nsDragService.cpp"

Comment 5

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8864401 [details]
Bug 1361949 - Add missing 'using namespace::widget' to widget/windows/nsDragService.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136092/diff/2-3/

Comment 6

[Farmer Tseng[:fatseng](inactive)]

Comment on attachment 8864401 [details]
Bug 1361949 - Add missing 'using namespace::widget' to widget/windows/nsDragService.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136092/diff/3-4/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ec64c93ac17
Add missing 'using namespace::widget' to widget/windows/nsDragService.cpp r=jwatt

Comment 8

[Farmer Tseng[:fatseng](inactive)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=687a7aff680b28e878799c69dd5e21aec1aff7d9

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4ec64c93ac17