1361976 - ESLint hooks should ensure that the ESLint setup is up to date

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Mark Banner (:standard8)]

Some things, e.g. globals, are contained within eslint-plugin-mozilla. We therefore want to make sure it is as up to date as possible so that we get the latest config.

Additionally, now we have hooks, developers may not be running ./mach eslint as much and hence this will ensure it is more likely to be kept updated.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1361976 - ESLint hooks should ensure that the ESLint setup is up to date.

Review commit: https://reviewboard.mozilla.org/r/137122/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137122/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8865467 [details]
Bug 1361976 - ESLint hooks should ensure that the ESLint setup is up to date.

https://reviewboard.mozilla.org/r/137120/#review142788

I'm not totally sold on putting this into the hooks but I guess we can see how it works out.

::: tools/lint/eslint/setup_helper.py:39
(Diff revision 1)
>  VERSION_RE = re.compile(r"^\d+\.\d+\.\d+$")
>  CARET_VERSION_RANGE_RE = re.compile(r"^\^((\d+)\.\d+\.\d+)$")
>  
> +# These two should be kept in sync.
>  EXTENSIONS = ['.js', '.jsm', '.jsx', '.xml', '.html', '.xhtml']
> +EXTENSIONS_RE = re.compile(r'.+\.(?:js|jsm|jsx|xml|html|xhtml)$')

Surely we can do this automatically.

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 8865467 [details]
Bug 1361976 - ESLint hooks should ensure that the ESLint setup is up to date.

https://reviewboard.mozilla.org/r/137122/#review142786

::: tools/lint/eslint/setup_helper.py:39
(Diff revision 1)
>  VERSION_RE = re.compile(r"^\d+\.\d+\.\d+$")
>  CARET_VERSION_RANGE_RE = re.compile(r"^\^((\d+)\.\d+\.\d+)$")
>  
> +# These two should be kept in sync.
>  EXTENSIONS = ['.js', '.jsm', '.jsx', '.xml', '.html', '.xhtml']
> +EXTENSIONS_RE = re.compile(r'.+\.(?:js|jsm|jsx|xml|html|xhtml)$')

Surely we can do that automatically?

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8865467 [details]
Bug 1361976 - ESLint hooks should ensure that the ESLint setup is up to date.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137122/diff/1-2/

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8865467 [details]
Bug 1361976 - ESLint hooks should ensure that the ESLint setup is up to date.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137122/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac59d773e2c2
ESLint hooks should ensure that the ESLint setup is up to date. r=mossop

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for busting ESlint (module setup_helper missing):

https://hg.mozilla.org/integration/autoland/rev/c1c081080d82eb6bc5a41bf8d3528807a8afac20

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ac59d773e2c278fa50f4cd94013fd1b4e0daa574&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=99427848&repo=autoland
> ImportError: No module named setup_helper

Comment 8

[Mark Banner (:standard8)]

Comment on attachment 8865467 [details]
Bug 1361976 - ESLint hooks should ensure that the ESLint setup is up to date.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137122/diff/3-4/

Comment 9

[Mark Banner (:standard8)]

Looks like I somehow got the patches messed up :-( Mozreview was also not giving decent interdiffs (and still isn't). However, I've got the right thing now which will hopefully work this time.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23e285c5aa70
ESLint hooks should ensure that the ESLint setup is up to date. r=mossop

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23e285c5aa70