stylo: Implement grid-template-areas

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: nox, Assigned: nox)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(3 attachments)

Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8864461 - Flags: review?(manishearth)
Attachment #8864461 - Flags: review?(bobbyholley)
Attachment #8864462 - Flags: review?(manishearth)
Attachment #8864462 - Flags: review?(bobbyholley)
Attachment #8864463 - Flags: review?(manishearth)
Attachment #8864463 - Flags: review?(bobbyholley)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8864461 [details]
Bug 1361985 - Add Servo bindings for GridTemplateAreasValue

https://reviewboard.mozilla.org/r/136144/#review139234
Attachment #8864461 - Flags: review?(manishearth) → review+
Attachment #8864461 - Flags: review?(bobbyholley)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8864462 [details]
Bug 1361985 - Implement grid-template-areas

https://reviewboard.mozilla.org/r/136146/#review139236
Attachment #8864462 - Flags: review?(manishearth) → review+
Attachment #8864462 - Flags: review?(bobbyholley)

Comment 6

2 years ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7bd313d7e80e
Add Servo bindings for GridTemplateAreasValue. r=Manishearth

Comment 8

2 years ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ee8d9001970
Whitelist Gecko_NewGridTemplateAreasValue from heap write hazard checking, since it pokes at stuff in the object it just created. r=me (CLOSED TREE)

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7bd313d7e80e
https://hg.mozilla.org/mozilla-central/rev/31163f835c34
https://hg.mozilla.org/mozilla-central/rev/1ee8d9001970
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Attachment #8864463 - Flags: review?(manishearth)
Attachment #8864463 - Flags: review?(bobbyholley)
You need to log in before you can comment on or make changes to this bug.