stylo: Implement grid-template-areas

RESOLVED FIXED in Firefox 55

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: nox, Assigned: nox)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

8 months ago
https://github.com/servo/servo/issues/16079
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Attachment #8864461 - Flags: review?(manishearth)
Attachment #8864461 - Flags: review?(bobbyholley)
Attachment #8864462 - Flags: review?(manishearth)
Attachment #8864462 - Flags: review?(bobbyholley)
Attachment #8864463 - Flags: review?(manishearth)
Attachment #8864463 - Flags: review?(bobbyholley)

Comment 4

8 months ago
mozreview-review
Comment on attachment 8864461 [details]
Bug 1361985 - Add Servo bindings for GridTemplateAreasValue

https://reviewboard.mozilla.org/r/136144/#review139234
Attachment #8864461 - Flags: review?(manishearth) → review+
Attachment #8864461 - Flags: review?(bobbyholley)

Comment 5

8 months ago
mozreview-review
Comment on attachment 8864462 [details]
Bug 1361985 - Implement grid-template-areas

https://reviewboard.mozilla.org/r/136146/#review139236
Attachment #8864462 - Flags: review?(manishearth) → review+
Attachment #8864462 - Flags: review?(bobbyholley)

Comment 6

8 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7bd313d7e80e
Add Servo bindings for GridTemplateAreasValue. r=Manishearth

Comment 7

8 months ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31163f835c34
Adjust test expectations. r=me

Comment 8

8 months ago
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1ee8d9001970
Whitelist Gecko_NewGridTemplateAreasValue from heap write hazard checking, since it pokes at stuff in the object it just created. r=me (CLOSED TREE)

Comment 9

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7bd313d7e80e
https://hg.mozilla.org/mozilla-central/rev/31163f835c34
https://hg.mozilla.org/mozilla-central/rev/1ee8d9001970
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Attachment #8864463 - Flags: review?(manishearth)
Attachment #8864463 - Flags: review?(bobbyholley)
You need to log in before you can comment on or make changes to this bug.