1362038 - Consider adding static analysis to prohibit Rooted locals inside loops

Status: NEW

(Core :: JavaScript Engine, enhancement, P3)

Description

[André Bargull [:anba]]

In bug 1321789, comment #4, Waldo wrote:
> Could you file a bug (CC me on it) to add static analysis to consider
> prohibiting Rooted locals inside loops?  I'd be interested in seeing the
> cases where we fall down, because my guess is this wouldn't really hinder
> readability that much (and if it did, we could have the Rooted outside the
> loop and a renamed Rooted& inside it), and it's something we're looking out
> for anyway, so we might as well get proper enforcement of it.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

So a prototype if this indicates we have a couple hundred instances of this to address if we wanted to turn this into a rule.

I've not yet had any success cross-correlating with some measure of frequency, so hard to identify top targets yet.