Closed Bug 1362117 Opened 7 years ago Closed 7 years ago

cairo_font_face_t's created from UnscaledFontFontconfig should hold a reference to the NativeFontResourceFontconfig that created them

Categories

(Core :: Graphics: Text, defect, P1)

55 Branch
All
Linux
defect

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr45 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- fixed

People

(Reporter: jrmuizel, Assigned: lsalzman)

References

Details

(Keywords: regression)

Attachments

(1 file)

Bad things happen if this isn't the case.
Blocks: 1362115
This is responsible for a lot of test failures with PaintLayerBlob with WebRender
Assignee: nobody → lsalzman
Comment on attachment 8864589 [details] [diff] [review]
keep NativeFontResourceFontconfig alive while its associated cairo_font_face_t is alive

Review of attachment 8864589 [details] [diff] [review]:
-----------------------------------------------------------------

Not beautiful, but it should work.
Attachment #8864589 - Flags: review?(jmuizelaar) → review+
Blocks: 1355931
Severity: normal → critical
Status: NEW → ASSIGNED
Has Regression Range: --- → yes
Keywords: regression
OS: Unspecified → Linux
Priority: -- → P1
Hardware: Unspecified → All
Version: unspecified → 55 Branch
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7c9ede7c201
keep NativeFontResourceFontconfig alive while its associated cairo_font_face_t is alive. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/a7c9ede7c201
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: