1362342 - POST data is lost from history entries on process switch.

Status: NEW

(Firefox :: Session Restore, enhancement)

Description

[Bob Owen (:bobowen)]

Currently we don't store the POST data associated with a history entry in the TabState cache in the parent.

This means that on process switch the history entries that we restore do not contain this POST data.

As we rely on the existence of the POST data to determine if the request was in fact a POST, this means that when we navigate to one of these history entries instead of the usual - do you want to resend - confirmation, a GET is performed instead.

Comment 1

[Mike de Boer [:mikedeboer]]

I'm afraid I don't quite follow... we store form data, irrespective of it being GET or POST... or whichever method you decide to use. What do you mean and which piece of info am I missing?

Comment 2

[Bob Owen (:bobowen)]

(In reply to Mike de Boer [:mikedeboer] from comment #1)
> I'm afraid I don't quite follow... we store form data, irrespective of it
> being GET or POST... or whichever method you decide to use. What do you mean
> and which piece of info am I missing?

From what I understand, we hold the form data for the current page in the parent, so we don't lose currently entered information on restore.

However, I'm fairly sure we don't store the historical POST data for each history entry [1] (if there were any).

[1] http://searchfox.org/mozilla-central/rev/6580dd9a4eb0224773897388dba2ddf5ed7f4216/docshell/shistory/nsISHEntry.idl#137

Comment 3

[Mike de Boer [:mikedeboer]]

Ah yes, that's clear. Thanks!