1362398 - Update Debugger Frontend (5/5/2017)

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Comment 1

[Jason Laster [:jlast]]

Attachment: bundle-5-5.patch

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2f3b9d752c36b365258318685ad77ec894f6d2c

Comment 3

[Jason Laster [:jlast]]

Attachment: bundle-5-5-2.patch

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8864860 [details] [diff] [review]
bundle-5-5-2.patch

Review of attachment 8864860 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! Just two localization notes to update.

Feel free to land with a green-ish try.

::: devtools/client/locales/en-US/debugger.properties
@@ +249,5 @@
>  # LOCALIZATION NOTE (editor.noResults): Editor Search bar message
>  # for when no results found.
>  editor.noResults=no results
>  
> +# LOCALIZATION NOTE (editor.searchResults.nextResults): Editor Search bar

editor.searchResults.nextResults -> editor.searchResults.nextResult

@@ +253,5 @@
> +# LOCALIZATION NOTE (editor.searchResults.nextResults): Editor Search bar
> +# tooltip for traversing to the Next Result
> +editor.searchResults.nextResult=Next Result
> +
> +# LOCALIZATION NOTE (editor.searchResults.prevResults): Editor Search bar

editor.searchResults.prevResults -> editor.searchResults.prevResult

Comment 5

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=14d49ae1dc2aaf135ac92e8012a084e131d7291e

Comment 6

[Jason Laster [:jlast]]

Attachment: bundle-5-5-3.patch

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d874a2e610d
Update Debugger Frontend. r=jdescottes

Comment 8

[Julian Descottes [:jdescottes]]

Comment on attachment 8865445 [details] [diff] [review]
bundle-5-5-3.patch

Thanks for addressing the comments!

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0d874a2e610d