Closed
Bug 1362398
Opened 8 years ago
Closed 8 years ago
Update Debugger Frontend (5/5/2017)
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jlast, Assigned: jlast)
References
Details
Attachments
(1 file, 2 obsolete files)
|
4.22 MB,
patch
|
jdescottes
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8864857 -
Flags: review?(jdescottes)
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2f3b9d752c36b365258318685ad77ec894f6d2c
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8864857 -
Attachment is obsolete: true
Attachment #8864857 -
Flags: review?(jdescottes)
Attachment #8864860 -
Flags: review?(jdescottes)
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8864860 [details] [diff] [review] bundle-5-5-2.patch Review of attachment 8864860 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, thanks! Just two localization notes to update. Feel free to land with a green-ish try. ::: devtools/client/locales/en-US/debugger.properties @@ +249,5 @@ > # LOCALIZATION NOTE (editor.noResults): Editor Search bar message > # for when no results found. > editor.noResults=no results > > +# LOCALIZATION NOTE (editor.searchResults.nextResults): Editor Search bar editor.searchResults.nextResults -> editor.searchResults.nextResult @@ +253,5 @@ > +# LOCALIZATION NOTE (editor.searchResults.nextResults): Editor Search bar > +# tooltip for traversing to the Next Result > +editor.searchResults.nextResult=Next Result > + > +# LOCALIZATION NOTE (editor.searchResults.prevResults): Editor Search bar editor.searchResults.prevResults -> editor.searchResults.prevResult
Attachment #8864860 -
Flags: review?(jdescottes) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=14d49ae1dc2aaf135ac92e8012a084e131d7291e
|
|
Assignee | |
Comment 6•8 years ago
|
||
Attachment #8864860 -
Attachment is obsolete: true
Attachment #8865445 -
Flags: review?(jdescottes)
|
|
||
Updated•8 years ago
|
Assignee: nobody → jlaster
Status: NEW → ASSIGNED
Priority: -- → P3
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d874a2e610d Update Debugger Frontend. r=jdescottes
|
|
||
Comment 8•8 years ago
|
||
Comment on attachment 8865445 [details] [diff] [review] bundle-5-5-3.patch Thanks for addressing the comments!
Attachment #8865445 -
Flags: review?(jdescottes) → review+
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0d874a2e610d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•