Closed Bug 1362410 Opened 7 years ago Closed 7 years ago

Intermittent docshell/test/browser/browser_bug1347823.js | "modified" == "page1" -

Categories

(Core :: DOM: Navigation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- fixed
firefox59 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: freesamael)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Blocks: 1347823
Assignee: nobody → sawang
Samael, do you think the intermittency here is hiding a legitimate bug?
Flags: needinfo?(sawang)
Priority: -- → P3
(In reply to Andrew Overholt [:overholt] from comment #20)
> Samael, do you think the intermittency here is hiding a legitimate bug?

I think not. Given there isn't an explicit notification when content viewers are dropped from bfcache, the test case has been written in a somewhat unreliable way:
http://searchfox.org/mozilla-central/rev/d08b24e613cac8c9c5a4131452459241010701e0/docshell/test/browser/browser_bug1347823.js#54-57

I haven't thought of a better solution except increasing the waiting time...
Flags: needinfo?(sawang)
Trying not to get email notification of this on every Monday...
Comment on attachment 8932352 [details]
Bug 1362410 - Make the setTimeout run on the same target as HistoryTracker.

https://reviewboard.mozilla.org/r/203398/#review208992
Attachment #8932352 - Flags: review?(bugs) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b680b6a0197e
Make the setTimeout run on the same target as HistoryTracker. r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b680b6a0197e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: