1362464 - Fix feedback from Storage Inspector's head.js methods

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, enhancement, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

In order to help write Storage Inspector tests e.g. when a bad row name or id is passed to a method, we do the following:

ok(false, "a bad id was passed etc.");
showAvailableIds();

The problem is that in the showAvailableIds() is a separate message than the test failure so in the log you get:

blah... a bad id was passed.
Long, long stack trace.
Available ids are:
  - blah
  - blah
  - blah

This patch simply attaches the showAvailableIds() output to the TEXT_UNEXPECTED_FAIL message so you don't need to go hunting through the logs to see which columns or rows are available.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1362464 - Fix feedback from Storage Inspector's head.js methods

Review commit: https://reviewboard.mozilla.org/r/136590/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136590/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8864935 [details]
Bug 1362464 - Fix feedback from Storage Inspector's head.js methods

https://reviewboard.mozilla.org/r/136590/#review140484

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9859494c47d
Fix feedback from Storage Inspector's head.js methods r=pbro

Comment 4

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/e9859494c47d