Closed Bug 1362478 Opened 7 years ago Closed 7 years ago

Content processes can't update coverage counters due to sandboxing

Categories

(Testing :: Code Coverage, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

I've tested disabling the sandbox locally with the example from bug 1362052 and the coverage looks right to me.
Attached patch PatchSplinter Review
Assignee: nobody → mcastelluccio
Status: NEW → ASSIGNED
Attachment #8864946 - Flags: review?(jmaher)
Comment on attachment 8864946 [details] [diff] [review]
Patch

Review of attachment 8864946 [details] [diff] [review]:
-----------------------------------------------------------------

awesome find
Attachment #8864946 - Flags: review?(jmaher) → review+
Pushed by mcastelluccio@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/996124fe6f8d
Disable sandbox in the code coverage build, as it prevents content processes from updating gcda files. r=jmaher
https://hg.mozilla.org/mozilla-central/rev/996124fe6f8d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: