Closed Bug 1362480 Opened 8 years ago Closed 6 years ago

esr52: we can't version bump for releases off a relbranch

Categories

(Release Engineering :: Release Automation, defect, P3)

Product:
Release Engineering
Component:
Release Automation
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: mozilla, Unassigned)

References

Details

bug 1355018 has us clone from mozilla-unified, which helps prevent clone timeouts. However, mozilla-unified doesn't contain relbranches. So cloning from mozilla-unified and tagging the relbranch revision fails: 09:59:57 INFO - Running main action method: tag 09:59:57 INFO - No bug - Tagging 120111e65bc4e9b99da97e9d046765de95fbac8c with FIREFOX_52_1_1esr_BUILD1, FIREFOX_52_1_1esr_RELEASE a=release CLOSED TREE 09:59:57 INFO - Running command: ['hg', 'tag', '-m', 'No bug - Tagging 120111e65bc4e9b99da97e9d046765de95fbac8c with FIREFOX_52_1_1esr_BUILD1, FIREFOX_52_1_1esr_RELEASE a=release CLOSED TREE', '-u', 'ffxbld <release@mozilla.com>', '-r', u'120111e65bc4e9b99da97e9d046765de95fbac8c', '-f', 'FIREFOX_52_1_1esr_BUILD1', 'FIREFOX_52_1_1esr_RELEASE'] in /builds/slave/rel-m-esr52-fx_version_bump-00/build/mozilla-esr52 09:59:57 INFO - Copy/paste: hg tag -m "No bug - Tagging 120111e65bc4e9b99da97e9d046765de95fbac8c with FIREFOX_52_1_1esr_BUILD1, FIREFOX_52_1_1esr_RELEASE a=release CLOSED TREE" -u "ffxbld <release@mozilla.com>" -r 120111e65bc4e9b99da97e9d046765de95fbac8c -f FIREFOX_52_1_1esr_BUILD1 FIREFOX_52_1_1esr_RELEASE 10:00:43 INFO - Traceback (most recent call last): 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 204, in _runcatch 10:00:43 INFO - return _dispatch(req) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 880, in _dispatch 10:00:43 INFO - cmdpats, cmdoptions) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 637, in runcommand 10:00:43 INFO - ret = _runcommand(ui, options, cmd, d) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 1010, in _runcommand 10:00:43 INFO - return checkargs() 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 971, in checkargs 10:00:43 INFO - return cmdfunc() 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/dispatch.py", line 877, in <lambda> 10:00:43 INFO - d = lambda: util.checksignature(func)(ui, *args, **cmdoptions) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/util.py", line 1036, in check 10:00:43 INFO - return func(*args, **kwargs) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/extensions.py", line 210, in closure 10:00:43 INFO - return func(*(args + a), **kw) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/util.py", line 1036, in check 10:00:43 INFO - return func(*args, **kwargs) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/hgext/mq.py", line 3539, in mqcommand 10:00:43 INFO - return orig(ui, repo, *args, **kwargs) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/util.py", line 1036, in check 10:00:43 INFO - return func(*args, **kwargs) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/commands.py", line 7010, in tag 10:00:43 INFO - r = scmutil.revsingle(repo, rev_).node() 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/scmutil.py", line 771, in revsingle 10:00:43 INFO - l = revrange(repo, [revspec]) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/scmutil.py", line 838, in revrange 10:00:43 INFO - return m(repo) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/revset.py", line 2570, in mfunc 10:00:43 INFO - result = getset(repo, subset, tree) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/revset.py", line 335, in getset 10:00:43 INFO - s = methods[x[0]](repo, subset, *x[1:]) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/revset.py", line 359, in stringset 10:00:43 INFO - x = repo[x].rev() 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/localrepo.py", line 533, in __getitem__ 10:00:43 INFO - return context.changectx(self, changeid) 10:00:43 INFO - File "/tools/python27-mercurial/lib/python2.7/site-packages/mercurial/context.py", line 514, in __init__ 10:00:43 INFO - _("unknown revision '%s'") % changeid) 10:00:43 INFO - RepoLookupError: unknown revision '120111e65bc4e9b99da97e9d046765de95fbac8c' 10:00:43 ERROR - abort: unknown revision '120111e65bc4e9b99da97e9d046765de95fbac8c'! 10:00:43 ERROR - Automation Error: hg not responding 10:00:43 ERROR - Return code: 255 We should either pull the revision from the main repo, or clone from the main repo, or something. I don't think relbranches in m-u will work.
As mentioned in bug 1365652: ESR52.1.1 was built off a relbranch, and the version bump died because it couldn't update to the version (the version bump clones mozilla-unified which doesn't contain relbranches). We could add an 'hg pull' to pull the relbranch from mozilla-esr52, and it might work. The workaround is to manually bump the version on default and manually transplant that to the relbranch.
Priority: -- → P3
This was fixed for non-esr in bug 1417697. Not sure if the same fix was applied to treescript?
Summary: we can't version bump for releases off a relbranch → esr52: we can't version bump for releases off a relbranch
Aki, do we still care about that?
Flags: needinfo?(aki)
I think we can resolve since esr52 is closed :)
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(aki)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.