Closed Bug 1362516 Opened 3 years ago Closed 3 years ago

Bug 1329737 broke TSAN build on linux

Categories

(Firefox Build System :: General, defect)

54 Branch
defect
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bwc, Assigned: froydnj)

References

Details

Attachments

(1 file)

I'm seeing the following error:

error: couldn't read "/home/bcampen/checkouts/mozilla-inbound/objdir-ff-tsan/toolkit/library/x86_64-unknown-linux-gnu/release/build/gleam-5d435a5e91c26082/out/gl_and_gles_bindings.rs": No such file or directory (os error 2)
  --> /home/bcampen/checkouts/mozilla-inbound/third_party/rust/gleam/src/lib.rs:16:5
   |
16 |     include!(concat!(env!("OUT_DIR"), "/gl_and_gles_bindings.rs"));
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


Backing out the patches from bug 1329737 (on a changeset shortly after they landed) fixes this error. It seems that a file isn't getting staged for tsan builds.
We disable bug 1329737 on ASan builds; we should probably do the same thing for TSan builds, unless we can figure out why passing TSan flags into the linker that Cargo invokes breaks things in peculiar ways.
For all the same reasons as why we disable the linker for ASan builds.

Does this work, Byron?
Attachment #8864979 - Flags: feedback?(docfaraday)
That seems to have done the trick! Thanks!
Attachment #8864979 - Flags: review?(giles)
Assignee: nobody → nfroyd
Comment on attachment 8864979 [details] [diff] [review]
disable custom Cargo linker for TSan builds

Review of attachment 8864979 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, rustc has experimental sanitizer support. Someone might want to experiment with this and RUSTFLAGS=-Z sanitizer=foo. In a different bug, of course.
Attachment #8864979 - Flags: review?(giles) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c03cb9ed456
disable custom Cargo linker for TSan builds; r=rillian,f=bwc
https://hg.mozilla.org/mozilla-central/rev/1c03cb9ed456
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Attachment #8864979 - Flags: feedback?(docfaraday)
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.