If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Bug 1329737 broke TSAN build on linux

RESOLVED FIXED in Firefox 55

Status

()

Core
Build Config
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: bwc, Assigned: froydnj)

Tracking

54 Branch
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 months ago
I'm seeing the following error:

error: couldn't read "/home/bcampen/checkouts/mozilla-inbound/objdir-ff-tsan/toolkit/library/x86_64-unknown-linux-gnu/release/build/gleam-5d435a5e91c26082/out/gl_and_gles_bindings.rs": No such file or directory (os error 2)
  --> /home/bcampen/checkouts/mozilla-inbound/third_party/rust/gleam/src/lib.rs:16:5
   |
16 |     include!(concat!(env!("OUT_DIR"), "/gl_and_gles_bindings.rs"));
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


Backing out the patches from bug 1329737 (on a changeset shortly after they landed) fixes this error. It seems that a file isn't getting staged for tsan builds.
(Assignee)

Comment 1

6 months ago
We disable bug 1329737 on ASan builds; we should probably do the same thing for TSan builds, unless we can figure out why passing TSan flags into the linker that Cargo invokes breaks things in peculiar ways.
(Assignee)

Comment 2

6 months ago
Created attachment 8864979 [details] [diff] [review]
disable custom Cargo linker for TSan builds

For all the same reasons as why we disable the linker for ASan builds.

Does this work, Byron?
Attachment #8864979 - Flags: feedback?(docfaraday)
(Reporter)

Comment 3

6 months ago
That seems to have done the trick! Thanks!
(Assignee)

Updated

6 months ago
Attachment #8864979 - Flags: review?(giles)
(Assignee)

Updated

6 months ago
Assignee: nobody → nfroyd
Comment on attachment 8864979 [details] [diff] [review]
disable custom Cargo linker for TSan builds

Review of attachment 8864979 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, rustc has experimental sanitizer support. Someone might want to experiment with this and RUSTFLAGS=-Z sanitizer=foo. In a different bug, of course.
Attachment #8864979 - Flags: review?(giles) → review+

Comment 5

6 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c03cb9ed456
disable custom Cargo linker for TSan builds; r=rillian,f=bwc

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1c03cb9ed456
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Updated

5 months ago
Attachment #8864979 - Flags: feedback?(docfaraday)
You need to log in before you can comment on or make changes to this bug.