1362595 - Clean up handling of hidden tabs in restoreWindow

Status: RESOLVED FIXED

(Firefox :: Session Restore, enhancement)

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1362595 - Clean up handling of hidden tabs in restoreWindow.

restoreWindow opens only new tabs rather than re-use pre-existing tabs anymore, so
there's no point in calling showTab anymore. hideTab also will not hide the selected
tab, so the "all tabs to be restored are hidden" case can't happen.

Review commit: https://reviewboard.mozilla.org/r/136710/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136710/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8865049 [details]
Bug 1362595 - Clean up handling of hidden tabs in restoreWindow.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136710/diff/1-2/

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8865049 [details]
Bug 1362595 - Clean up handling of hidden tabs in restoreWindow.

https://reviewboard.mozilla.org/r/136710/#review140666

Nice cleanup :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c1cde4075380
Clean up handling of hidden tabs in restoreWindow. r=mikedeboer

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c1cde4075380