layout/base/RestyleTracker.h:262:33: error: 'ProfilerFeature' has not been declared

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jbeich, Unassigned)

Tracking

({regression})

Trunk
mozilla55
Unspecified
FreeBSD
regression
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
Gecko Profiler is not implemented on many Tier3 platforms (e.g. Linux on non-x86, iOS, Darwin/X11, BSDs, Solaris) but "struct ProfilerFeature" definition is gated on it.

In file included from layout/base/nsRefreshDriver.cpp:50:
In file included from objdir/dist/include/mozilla/GeckoRestyleManager.h:18:
layout/base/RestyleTracker.h:262:33: error: use of undeclared identifier
      'ProfilerFeature'
    if (profiler_feature_active(ProfilerFeature::Restyle)) {
                                ^
1 error generated.

http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/2076/steps/build/logs/stdio (openbsd)
http://buildbot.rhaalovely.net/builders/mozilla-central-freebsd-amd64/builds/1181/steps/build/logs/stdio
(Reporter)

Updated

2 years ago
status-firefox53: --- → unaffected
status-firefox54: --- → unaffected
status-firefox55: --- → affected
status-firefox-esr52: --- → unaffected
Keywords: regression
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8865053 [details]
Bug 1362598 - Always define ProfilerFeature as there's no stub.

https://reviewboard.mozilla.org/r/136722/#review140226
Attachment #8865053 - Flags: review?(mstange) → review+
(Reporter)

Updated

2 years ago
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ae2b60255707
Always define ProfilerFeature as there's no stub. r=mstange
Keywords: checkin-needed

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ae2b60255707
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.