1362598 - layout/base/RestyleTracker.h:262:33: error: 'ProfilerFeature' has not been declared

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Jan Beich]

Gecko Profiler is not implemented on many Tier3 platforms (e.g. Linux on non-x86, iOS, Darwin/X11, BSDs, Solaris) but "struct ProfilerFeature" definition is gated on it.

In file included from layout/base/nsRefreshDriver.cpp:50:
In file included from objdir/dist/include/mozilla/GeckoRestyleManager.h:18:
layout/base/RestyleTracker.h:262:33: error: use of undeclared identifier
      'ProfilerFeature'
    if (profiler_feature_active(ProfilerFeature::Restyle)) {
                                ^
1 error generated.

http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/2076/steps/build/logs/stdio (openbsd)
http://buildbot.rhaalovely.net/builders/mozilla-central-freebsd-amd64/builds/1181/steps/build/logs/stdio

Comment 1

[Jan Beich]

Attachment: Bug 1362598 - Always define ProfilerFeature as there's no stub.

Review commit: https://reviewboard.mozilla.org/r/136722/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136722/

Comment 2

[Jan Beich]

Comment on attachment 8865053 [details]
Bug 1362598 - Always define ProfilerFeature as there's no stub.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136722/diff/1-2/

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8865053 [details]
Bug 1362598 - Always define ProfilerFeature as there's no stub.

https://reviewboard.mozilla.org/r/136722/#review140226

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae2b60255707
Always define ProfilerFeature as there's no stub. r=mstange

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ae2b60255707