1362880 - Reserve storage for 10 RowInfo objects in nsTableRowGroupFrame::CalculateRowBSizes()

Status: RESOLVED FIXED

(Core :: Layout: Tables, enhancement)

Comment 1

[(no longer active)]

Attachment: Reserve storage for 10 RowInfo objects in nsTableRowGroupFrame::CalculateRowBSizes()

I noticed this when profiling bug 1357621.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 8865245 [details] [diff] [review]
Reserve storage for 10 RowInfo objects in nsTableRowGroupFrame::CalculateRowBSizes()

r=dbaron (although I'd suggest increasing to 16 or 32, perhaps?)

I wish we had a way to do this with alloca(), though (conditional on numRows < 128 or similar)

Comment 3

[(no longer active)]

I don't know how to use _alloca() with nsTArray, but 32 sounds good! :-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba4487376f2c
Reserve storage for 10 RowInfo objects in nsTableRowGroupFrame::CalculateRowBSizes(); r=dbaron

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a753ca96dfb
follow-up: Bump up the reserved size to 32

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ba4487376f2c
https://hg.mozilla.org/mozilla-central/rev/6a753ca96dfb