Closed Bug 1362880 Opened 4 years ago Closed 4 years ago

Reserve storage for 10 RowInfo objects in nsTableRowGroupFrame::CalculateRowBSizes()

Categories

(Core :: Layout: Tables, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Comment on attachment 8865245 [details] [diff] [review]
Reserve storage for 10 RowInfo objects in nsTableRowGroupFrame::CalculateRowBSizes()

r=dbaron (although I'd suggest increasing to 16 or 32, perhaps?)

I wish we had a way to do this with alloca(), though (conditional on numRows < 128 or similar)
Attachment #8865245 - Flags: review?(dbaron) → review+
Component: Layout → Layout: Tables
I don't know how to use _alloca() with nsTArray, but 32 sounds good! :-)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba4487376f2c
Reserve storage for 10 RowInfo objects in nsTableRowGroupFrame::CalculateRowBSizes(); r=dbaron
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a753ca96dfb
follow-up: Bump up the reserved size to 32
https://hg.mozilla.org/mozilla-central/rev/ba4487376f2c
https://hg.mozilla.org/mozilla-central/rev/6a753ca96dfb
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.