Stop using the :not(:target) selector in sync-illustration.svg

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks 1 bug)

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
As part of fixing bug 1358998 we should stop using the :not(:target) selector in:

https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/fxa/sync-illustration.svg
Assignee

Comment 1

2 years ago
Posted patch patchSplinter Review
Attachment #8865264 - Flags: review?(dao+bmo)
Comment on attachment 8865264 [details] [diff] [review]
patch

It's a bit unfortunate that this repeats #bfcbd3 so often. I guess there's no way to use that color in the SVG by default with optional context-fill?
Attachment #8865264 - Flags: review?(dao+bmo) → review+
Assignee

Comment 3

2 years ago
Sadly not.

Comment 4

2 years ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc9ff81ed453
Stop using the :not(:target) selector in sync-illustration.svg. r=dao

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/dc9ff81ed453
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.