1362918 - Extend the blacklist of disabling adaptive playback feature for some specific Galaxy S4 model

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[James Cheng[:JamesCheng]]

For bug 1360626, comment 37 and comment 38... we need to extend the blacklist range to cover those two models.

Hope it works.

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1362918 - Extend the blacklist to cover certain Galaxy S4 models.

Review commit: https://reviewboard.mozilla.org/r/136946/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136946/

Comment 2

[John Lin [:jhlin][:jolin]]

Comment on attachment 8865304 [details]
Bug 1362918 - Extend the blacklist to cover certain Galaxy S4 models.

https://reviewboard.mozilla.org/r/136946/#review139908

Comment 4

[James Cheng[:JamesCheng]]

Hi Jens and clgillum,

Would you please help me to check if this apk works on your S4 devices?

https://queue.taskcluster.net/v1/task/X5jm3iM0RNKKE447EWDXTA/runs/0/artifacts/public/build/target.apk

If so, I will check in the code and request uplifting.

Thanks.

Comment 5

[clgillum]

That didn't fix it.  Youtube videos are still playing with horizontal slices that are out of order and only in gray.  They play through the default browser correctly.  This started about a week ago.  Is this the same bug symptoms as S3 or something else?  Would a screen capture of the playback be useful?

Comment 6

[James Cheng[:JamesCheng]]

If the symptom is similar to https://bugzilla.mozilla.org/attachment.cgi?id=8862934&action=edit

I think they are the same root cause.

But I do add the model you provided into blacklist...

Could you please let me know how you get the model ID and could you please delete the current app and reinstall from https://queue.taskcluster.net/v1/task/X5jm3iM0RNKKE447EWDXTA/runs/0/artifacts/public/build/target.apk
and test it again(please give me the screen shot if possible)?

Thanks

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

From the duplicate bug, sounds like 53 and up are affected. 
Kevin, were you able to reproduce this? 
Or, Ioana, does your team have this hardware for testing?

Comment 8

[Kevin Brosnan [Ex-Mozilla]]

I don't believe either of us have hardware. Affected users from comment 0 of the duped bug are our best bet.

Comment 9

[Jens]

Fine with me, apk working. videos ok.

Comment 10

[James Cheng[:JamesCheng]]

Hi clgillum,

Since the apk works fine for Jens, could you please use below apk to test again and provide me the log from adb logcat which I dump the ModelId.

Maybe you can grep 'GeckoHardwareCodecCapabilityUtils: ModelID'.

https://queue.taskcluster.net/v1/task/Rlnf-YM6SjCfZjz6qZH1fA/runs/0/artifacts/public/build/target.apk

Thanks.

Comment 11

[James Cheng[:JamesCheng]]

Hi clgillum,

I saw your screenshot and I suspect that the model ID I listed to blacklist is not the same with the API Build.MODEL returns.

The screenshot shows "SEPF_SGH-M919" and if Build.MODEL prints the same string, I will modify the blacklist.

Please see comment 10 and give me some clue,

Thank you!

Comment 12

[John]

I have the same bug on my S4 SGH-I337 Android 4.4.2 with the last version 53.0.2

Comment 13

[James Cheng[:JamesCheng]]

(In reply to John from comment #12)
> I have the same bug on my S4 SGH-I337 Android 4.4.2 with the last version
> 53.0.2
Hi John, 
Would you please also provide me the log with model Id string as comment 10 said.

I will add the string into blacklist

Thanks

Comment 14

[James Cheng[:JamesCheng]]

Hi clgillum,

This apk just add the SEPF_SGH-M919 into blacklist.

Hope it works on your device, 

Please also test this apk.

Many thanks.


https://queue.taskcluster.net/v1/task/O5UlEv_PSt2nBTq_ElQWNQ/runs/0/artifacts/public/build/target.apk

Comment 15

[John]

I don't know how to get the log from adb logcat, but after reading the specs from SGH-M919 and SGH-I337 at https://en.wikipedia.org/wiki/Samsung_Galaxy_S4#Model_variants they have the same hardware, I can test the apk from comment 10 if you want.

Comment 16

[James Cheng[:JamesCheng]]

Comment on attachment 8865304 [details]
Bug 1362918 - Extend the blacklist to cover certain Galaxy S4 models.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136946/diff/1-2/

Comment 17

[James Cheng[:JamesCheng]]

(In reply to John from comment #15)
> I don't know how to get the log from adb logcat, but after reading the specs
> from SGH-M919 and SGH-I337 at
> https://en.wikipedia.org/wiki/Samsung_Galaxy_S4#Model_variants they have the
> same hardware, I can test the apk from comment 10 if you want.
Hi John,

It will be good if you know how to get the log.

I add the SGH-I337 into blacklist and please use below apk to test if it works.

https://queue.taskcluster.net/v1/task/Q_Ju82N3SQWPnR1GrO1RgQ/runs/0/artifacts/public/build/target.apk

Thanks.

Comment 18

[John]

Hi James,

You need the full log file or only a screenshot from the model Id string?

Comment 19

[John]

OK James,

I've tested the apk from comment 10 and the video bug was still there, here is the string:

GeckoHardwareCodecCapabilityUtils,Nightly,ModelID = SAMSUNG-SGH-I337

Also tested the apk from comment 17 and video was fixed, let me know if you still need the log file.

Comment 20

[James Cheng[:JamesCheng]]

Hi John,

Thank you so much that you provides the ModelId from log, that's enough :),

Glad to hear that the root cause is the same as S3 case.

I've added it to the blacklist in this patch.

I'm waiting for clgillum's feedback to see if I can do more.

Thanks.

Comment 21

[James Cheng[:JamesCheng]]

Comment on attachment 8865304 [details]
Bug 1362918 - Extend the blacklist to cover certain Galaxy S4 models.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136946/diff/2-3/

Comment 22

[James Cheng[:JamesCheng]]

Look again the impl in google

https://cs.chromium.org/chromium/src/media/base/android/java/src/org/chromium/media/MediaCodecUtil.java?ssfr=1&type=cs&q=isAdaptivePlaybackBlacklisted&l=421

They only think the issue happened on 4.4.2.

But for clgillum's device, it's 4.4.4, so I remove this check to see if it works

Hi clgillum,

Please use this apk to check if it is fixed.

https://queue.taskcluster.net/v1/task/fekKcg0BTQu2_gbxQZvMlA/runs/0/artifacts/public/build/target.apk

Thank you

Comment 23

[James Cheng[:JamesCheng]]

Please see comment 22. Thanks.

Comment 24

[clgillum]

That worked!  Thanks James

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0398b6fa1a0e
Extend the blacklist to cover certain Galaxy S4 models. r=jolin

Comment 26

[James Cheng[:JamesCheng]]

Comment on attachment 8865304 [details]
Bug 1362918 - Extend the blacklist to cover certain Galaxy S4 models.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1317239
[User impact if declined]: Video corruption on some devices
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: Would be helpful. Simply play a video on an affected device such as a Galaxy S4.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: It only disables a feature that was only recently added on a subset of devices.
[String changes made/needed]: None

Comment 27

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0398b6fa1a0e

Comment 28

[Gerry Chang [:gchang]]

Hi Ioana,
Do you have a Galaxy S4 device to verify this issue?

Comment 29

[Gerry Chang [:gchang]]

Also NI Mihai to support verifying the issue.

Comment 30

[Liz Henry (:lizzard) (relman/hg->git project)]

From comment 8 above, no one from QE at Mozilla has the hardware. 
We can ask the users who reported the issue on SUMO 
(https://support.mozilla.org/en-US/questions/1159073, https://support.mozilla.org/en-US/questions/1158437)

Comment 31

[Liz Henry (:lizzard) (relman/hg->git project)]

Jens, clgillum, if you can try the latest Nightly on your S4 devices to see if you can verify that it's fixed, and comment here, that would be super helpful.   If someone can verify in the next day or so, I'm ok with bringing this fix to 53.

Comment 32

[Jens]

Hi Liz, 
https://queue.taskcluster.net/v1/task/fekKcg0BTQu2_gbxQZvMlA/runs/0/artifacts/public/build/target.apk 
-fixed the issue here.

Comment 33

[Jens]

Oh..., sorry Liz. The LATEST nightly. -Issue fixed on my device.

Comment 34

[Liz Henry (:lizzard) (relman/hg->git project)]

Thank you Jens!   I think we can probably bring this fix to 54.

Comment 35

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8865304 [details]
Bug 1362918 - Extend the blacklist to cover certain Galaxy S4 models.

Let's uplift to beta so this will be in place for the 54 release. 
We don't need aurora uplift anymore because of the Dawn project. 

So far, I don't think this is a widespread enough problem to justify shipping a dot release to fix it.

Comment 36

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0884adb687d1

Comment 37

[Liz Henry (:lizzard) (relman/hg->git project)]

At this point I'm not expecting any further 53 releases.