136297 - Parallel builds in ldapcsdk failing because of race condition in dist

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP C SDK, defect)

Description

[Donnie Cranford]

dmose asked me to file a bug on him for this problem...

Steps to reproduce 

1. in your .mozconfig have a MOZ_MAKE_FLAGS=-j4 or higher
2. run gmake -f client.mk build


Actual Result :
gmake[5]: Entering directory `/export/home/mozilla/directory/c-sdk/ldap/include'
../../config/./nsinstall -D /export/home/mozilla/dist/public/ldap
perl ./../build/replace.pl \
        LDAP_VENDOR_NAME="mozilla.org" \
                LDAP_VENDOR_VERSION="500" \
                < ldap-standard-tmpl.h >
/export/home/mozilla/dist/public/ldap/ldap-standard.h
/bin/sh: /export/home/mozilla/dist/public/ldap/ldap-standard.h: cannot create
gmake[5]: *** [/export/home/mozilla/dist/public/ldap/ldap-standard.h] Error 1


Expected Result :
Continue compiling in parallel

----------------------------------------------------------------

just for public knowledge this has been confirmed on Solaris 8 and Solaris 9

using gmake 3.79.1


Thanks

-dcran-

Comment 1

[Donnie Cranford]

making dmose the owner

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Need to create $(DIST) if it doesn't already exist before running the script.

Comment 3

[Donnie Cranford]

Attachment: patch as suggested by Dauphin

Comment 4

[Donnie Cranford]

Attachment: patch as stated by Dauphin

Comment 5

[Donnie Cranford]

i have tested this patch and verified it works, lets go 

r=dcran, just needs sr= and a=

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 78296 [details] [diff] [review]
patch as stated by Dauphin

r=dmose

Comment 7

[Asa Dotzler [:asa]]

Comment on attachment 78296 [details] [diff] [review]
patch as stated by Dauphin

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 8

[hacker formerly known as [e-mail]]

Patch has been checked into the moz1.0 branch and the ldap50client branch.