1362990 - InvalidCookieDomainError not defined in errors

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[David Burns :automatedtester]

from https://github.com/mozilla/geckodriver/issues/719

We are using InvalidCookieDomainError but it is not defined in error.js

Comment 1

[David Burns :automatedtester]

Attachment: Bug 1362990: Implement InvalidCookieDomainError in Marionette;

This implements the error Invalid Cookie Domain as described in
https://w3c.github.io/webdriver/webdriver-spec.html#dfn-invalid-cookie-domain
which is used in the Marionette Cookie Handling code.

Review commit: https://reviewboard.mozilla.org/r/137104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137104/

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 8865437 [details]
Bug 1362990: Implement InvalidCookieDomainError in Marionette;

https://reviewboard.mozilla.org/r/137104/#review140110

Thanks for doing this change!

Comment 3

[David Burns :automatedtester]

Comment on attachment 8865437 [details]
Bug 1362990: Implement InvalidCookieDomainError in Marionette;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137104/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b2071046994
Implement InvalidCookieDomainError in Marionette; r=ato

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8b2071046994