1362996 - Implement browsingData.removeCache WebExtension API method on android

Status: VERIFIED FIXED

(WebExtensions :: Android, enhancement, P5)

Description

[Tushar Saini (:shatur)]

This method clears the browser's cache. Doc can be found at [1].

[1]. https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browsingData/removeCache

Comment 1

[Tushar Saini (:shatur)]

Attachment: Bug 1362996 - Implement browsingData.removeCache WebExtension API method on android.

Review commit: https://reviewboard.mozilla.org/r/151582/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151582/

Comment 2

[Tushar Saini (:shatur)]

Comment on attachment 8880221 [details]
Bug 1362996 - Implement browsingData.removeCache WebExtension API method on android.

https://reviewboard.mozilla.org/r/151582/#review156554

::: commit-message-ced0f:1
(Diff revision 1)
> +Bug 1362996 - Implement browsingData.removeCache WebExtension API method on android.

Hey Matthew,

For desktop, removeCache() don not provide option to delete it wrt to time. Also, I was not able to find any methodby which we can add such functionality on fennec. So should we implement this as we've done for desktop or you've any other preference?

Thanks!

Comment 3

[Tushar Saini (:shatur)]

Comment on attachment 8880221 [details]
Bug 1362996 - Implement browsingData.removeCache WebExtension API method on android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151582/diff/1-2/

Comment 4

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8880221 [details]
Bug 1362996 - Implement browsingData.removeCache WebExtension API method on android.

https://reviewboard.mozilla.org/r/151582/#review164710

Looks good. Nice work, Tushar. Just one comment about the implementation.

::: mobile/android/components/extensions/ext-browsingData.js:97
(Diff revision 2)
> +
>          removeCookies(options) {
>            return clearCookies(options);
>          },
> +
> +        async removeCache(options){

It doesn't seem like this needs to be `async`.

Comment 5

[Tushar Saini (:shatur)]

Comment on attachment 8880221 [details]
Bug 1362996 - Implement browsingData.removeCache WebExtension API method on android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151582/diff/2-3/

Comment 6

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8880221 [details]
Bug 1362996 - Implement browsingData.removeCache WebExtension API method on android.

https://reviewboard.mozilla.org/r/151582/#review166934

Thanks for making that change, Tushar. It looks good now. This will still need a final review from a WebExtensions peer before landing.

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8880221 [details]
Bug 1362996 - Implement browsingData.removeCache WebExtension API method on android.

https://reviewboard.mozilla.org/r/151582/#review167388

Comment 8

[:Grisha Kruglov]

Comment on attachment 8880221 [details]
Bug 1362996 - Implement browsingData.removeCache WebExtension API method on android.

https://reviewboard.mozilla.org/r/151582/#review168968

Two r+ are probably enough :)

Comment 9

[Tushar Saini (:shatur)]

Try looks good, we can land this!!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea862a5c0067
Implement browsingData.removeCache WebExtension API method on android. r=bsilverberg,mixedpuppy

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ea862a5c0067

Comment 12

[CosminB]

Attachment: Bug1362996.gif

This issue is verified as fixed on Fennec 57.0 (20171112125738), Fennec 58.0b3 (20171113173459) and Fennec 59.0a1 (2017-11-16) under Android 6.0.1.

The cache is removed from the storage.

Extension used: https://addons-dev.allizom.org/en-US/firefox/addon/browsingdataremovecacheandroid/  

Please see the attached video.