Closed
Bug 1363037
Opened 7 years ago
Closed 7 years ago
Build bustage: dom/VRServiceTest.h(38): error C2039: 'VRDisplayInfo': is not a member of 'mozilla::gfx'
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
Attachments
(1 file)
622 bytes,
patch
|
kip
:
review+
|
Details | Diff | Splinter Review |
VS2015, debug build (32bit) 3:42.28 c:\_\obj\mozilla-central1\_obj-browser-debug\dist\include\mozilla/dom/VRServiceTest.h(38): error C2039: 'VRDisplayInfo': is not a member of 'mozilla::gfx' 3:42.28 c:\_\obj\mozilla-central1\_obj-browser-debug\dist\include\nsIWidget.h(65): note: see declaration of 'mozilla::gfx' 3:42.29 c:\_\obj\mozilla-central1\_obj-browser-debug\dist\include\mozilla/dom/VRServiceTest.h(38): error C3646: 'mDisplayInfo': unknown override specifier 3:42.29 c:\_\obj\mozilla-central1\_obj-browser-debug\dist\include\mozilla/dom/VRServiceTest.h(38): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int A missing #include "gfxVR.h"
Attachment #8865446 -
Flags: review?(kgilbert)
Assignee | ||
Updated•7 years ago
|
Attachment #8865446 -
Attachment is patch: true
Comment 1•7 years ago
|
||
Comment on attachment 8865446 [details] [diff] [review] v1 (add the missing include) This LGTM, thanks!
Attachment #8865446 -
Flags: review?(kgilbert) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/aeade87cc0e8 Add missing gfxVR.h include to VRServiceTest.h to fix bustage. r=kip
Keywords: checkin-needed
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/aeade87cc0e8
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•