1363040 - tracking-protection-16.svg is loaded in windows that don't need it

Status: RESOLVED FIXED

(Firefox :: Site Identity, enhancement, P4)

Description

[Dão Gottwald [:dao]]

<jwatt> I'm seeing chrome://browser/skin/tracking-protection-16.svg#enabled load during startup
<jwatt> loading the start page
<jwatt> but I'm not seeing that displayed
<jwatt> do you know where I'd see it?
<dao> in the identity block in private windows
<dao> or with privacy.trackingprotection.enabled = true in non-private windows
<jwatt> huh
<jwatt> I wonder why that's loading during startup when no private windows are opened
<dao> I think it's because we slide in the icon rather than hiding it. :/ http://searchfox.org/mozilla-central/source/browser/themes/shared/identity-block/identity-block.inc.css#140-150

Comment 1

[Johann Hofmann [:johannh]]

Potentially something for photon-perf though we don't know how much impact this really has.

Comment 2

[Johann Hofmann [:johannh]]

This is now a whitelist item in the browser_startup_images.js test.

https://searchfox.org/mozilla-central/rev/31311070d9860b24fe4a7a36976c14b328c16208/browser/base/content/test/performance/browser_startup_images.js#85

Comment 3

[:prathiksha]

Attachment: Bug 1363040 - Stop loading tracking-protection-16.svg in windows that don't display it.

Review commit: https://reviewboard.mozilla.org/r/210198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/210198/

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8939889 [details]
Bug 1363040 - Stop loading tracking-protection-16.svg in windows that don't display it.

https://reviewboard.mozilla.org/r/210198/#review215910

Thanks for tackling this!

::: browser/themes/shared/identity-block/identity-block.inc.css:177
(Diff revision 1)
>    margin-inline-end: -20px;
>    pointer-events: none;
>    opacity: 0;
>    /* Only animate the shield in, when it disappears hide it immediately. */
>    transition: none;
> +  display: none;

While this should solve the problem, we now have the issue that the tracking protection icon is skipping its animation, which it should not.

Another approach could be unsetting the list-style-image instead of using display: none. That could have the same effect but retain the animation.

Can you try that? :)

Thanks!

Comment 5

[:prathiksha]

Comment on attachment 8939889 [details]
Bug 1363040 - Stop loading tracking-protection-16.svg in windows that don't display it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210198/diff/1-2/

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8939889 [details]
Bug 1363040 - Stop loading tracking-protection-16.svg in windows that don't display it.

https://reviewboard.mozilla.org/r/210198/#review216278

Amazing, thank you!

::: browser/themes/shared/identity-block/identity-block.inc.css:177
(Diff revision 2)
>    margin-inline-end: -20px;
>    pointer-events: none;
>    opacity: 0;
>    /* Only animate the shield in, when it disappears hide it immediately. */
>    transition: none;
> +  list-style-image: unset;

Nit: list-style-image: none might be a bit more accurate since we don't want to reset the image to the parent value but just avoid displaying anything at all.

Comment 7

[:prathiksha]

Comment on attachment 8939889 [details]
Bug 1363040 - Stop loading tracking-protection-16.svg in windows that don't display it.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/210198/diff/2-3/

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The issue still open in Review Board has to set to fixed else Review Board will prevent the landing of the patch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d19176e7d25
Stop loading tracking-protection-16.svg in windows that don't display it. r=johannh

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9d19176e7d25