stylo: Figure out why dynamic-mask-01.svg and anim-view-01.svg#view cause timeout

RESOLVED FIXED in Firefox 55

Status

()

Core
CSS Parsing and Computation
P2
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: jeremychen, Unassigned)

Tracking

(Blocks: 1 bug)

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

3 months ago
Due to lack of smil support for stylo, lots of smil related SVG reftests cause test timeout instead of test failure. I suspect the lack of smil support prevents the tests from removing "reftest-wait". So, I intent to skip a bunch of reftests (see layout/reftests/svg/smil/style/reftest.list) in Bug 1359343. We should re-enable them once we get SVG (SMIL) animations to work for stylo in Bug 1302948.
(Reporter)

Comment 1

3 months ago
To be more specific, these timeout issues only appear on stylo debug build!
Priority: -- → P2
Most of the tests have been enabled in bug 1363880.
Rest of failures (test that causes timeout) are:
 layout/reftests/svg/dynamic-mask-01.svg
 layout/reftests/svg/smil/anim-view-01.svg#view
Summary: stylo: Re-enable smil related SVG reftests → stylo: Figure out why dynamic-mask-01.svg and anim-view-01.svg#view cause timeout
It seems that dynamic-mask-01.svg can be passed now, I guess bug 1365629 fixed it.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=da566cdd159fae87e44e18065b7bbf6da67471e5

Updated

2 months ago
Keywords: leave-open
Comment hidden (mozreview-request)
(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
>  layout/reftests/svg/smil/anim-view-01.svg#view

This one depends on Bug 1354406.
Depends on: 1354406
No longer depends on: 1302948
Comment hidden (mozreview-request)
(In reply to Hiroyuki Ikezoe (:hiro) from comment #5)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> >  layout/reftests/svg/smil/anim-view-01.svg#view
> 
> This one depends on Bug 1354406.

I decided to add annotations for such kind of tests.
Blocks: 1302948
No longer depends on: 1354406
Keywords: leave-open

Comment 8

2 months ago
mozreview-review
Comment on attachment 8869907 [details]
Bug 1363045 - Don't skip dynamic-mask-01.svg.

https://reviewboard.mozilla.org/r/141458/#review144986
Attachment #8869907 - Flags: review?(bbirtles) → review+

Comment 9

2 months ago
mozreview-review
Comment on attachment 8869912 [details]
Bug 1363045 - Annotate bug number for reftests which don't work because of id anchor.

https://reviewboard.mozilla.org/r/141472/#review144988
Attachment #8869912 - Flags: review?(bbirtles) → review+
Thank you!

Comment 11

2 months ago
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1d7739f6d550
Don't skip dynamic-mask-01.svg. r=birtles
https://hg.mozilla.org/integration/autoland/rev/039da694c69f
Annotate bug number for reftests which don't work because of id anchor. r=birtles

Comment 12

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1d7739f6d550
https://hg.mozilla.org/mozilla-central/rev/039da694c69f
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.