1363045 - stylo: Figure out why dynamic-mask-01.svg and anim-view-01.svg#view cause timeout

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Jeremy Chen ([e-mail])]

Due to lack of smil support for stylo, lots of smil related SVG reftests cause test timeout instead of test failure. I suspect the lack of smil support prevents the tests from removing "reftest-wait". So, I intent to skip a bunch of reftests (see layout/reftests/svg/smil/style/reftest.list) in Bug 1359343. We should re-enable them once we get SVG (SMIL) animations to work for stylo in Bug 1302948.

Comment 1

[Jeremy Chen ([e-mail])]

To be more specific, these timeout issues only appear on stylo debug build!

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Most of the tests have been enabled in bug 1363880.
Rest of failures (test that causes timeout) are:
 layout/reftests/svg/dynamic-mask-01.svg
 layout/reftests/svg/smil/anim-view-01.svg#view

Comment 3

[Hiroyuki Ikezoe (:hiro)]

It seems that dynamic-mask-01.svg can be passed now, I guess bug 1365629 fixed it.

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=da566cdd159fae87e44e18065b7bbf6da67471e5

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1363045 - Don't skip dynamic-mask-01.svg.

Review commit: https://reviewboard.mozilla.org/r/141458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141458/

Comment 5

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
>  layout/reftests/svg/smil/anim-view-01.svg#view

This one depends on Bug 1354406.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1363045 - Annotate bug number for reftests which don't work because of id anchor.

Review commit: https://reviewboard.mozilla.org/r/141472/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141472/

Comment 7

[Hiroyuki Ikezoe (:hiro)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #5)
> (In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> >  layout/reftests/svg/smil/anim-view-01.svg#view
> 
> This one depends on Bug 1354406.

I decided to add annotations for such kind of tests.

Comment 8

[Brian Birtles (:birtles)]

Comment on attachment 8869907 [details]
Bug 1363045 - Don't skip dynamic-mask-01.svg.

https://reviewboard.mozilla.org/r/141458/#review144986

Comment 9

[Brian Birtles (:birtles)]

Comment on attachment 8869912 [details]
Bug 1363045 - Annotate bug number for reftests which don't work because of id anchor.

https://reviewboard.mozilla.org/r/141472/#review144988

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Thank you!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d7739f6d550
Don't skip dynamic-mask-01.svg. r=birtles
https://hg.mozilla.org/integration/autoland/rev/039da694c69f
Annotate bug number for reftests which don't work because of id anchor. r=birtles

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1d7739f6d550
https://hg.mozilla.org/mozilla-central/rev/039da694c69f