1363049 - Web Apps - Web apps are reopened when closing a tab opened from them

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Oana Horvath [:ohorvath]]

Device: Nexus 6 (Android 7);
Build: Nightly 55.0a1 (2017-05-08);

Steps to reproduce:
1. Open the twitter web app and open an external link (some external links open in the browser).
2. Close the tab opened in Nightly (with the web app closed/minimized.).

Expected result:
Tab is closed, the web app remains closed/minimized.

Actual result:
The web app from which the tab belonged, re-opens/maximizes.

note: It doesn't behave like this on Chrome.

Comment 1

[Jan Henning [:JanH]]

When closing a tab, we're selecting it's parent tab, which in this case happens to be a web app. If we don't want this, I think we could e.g. restrict this to usage of the back button (as opposed to closing a tab from the tabs tray).

Comment 2

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

[triage] 
undefined for P1 or P2, we would like to make the call once dale had solution to fix
Also NI UX to reconfirm the expected behavior

Comment 3

[Jack Lin[:jacklin]]

If we close the opened tab from PWA then back to the web app directly, some use cases may be confusing. For example, if there are many tabs on the tab tray, users close some tabs then still stay in nightly, but close the opened tab from PWA then close nightly and back to the web app. I think this makes users confused.

So, my expectation is what you mentioned "Tab is closed, the web app remains closed/minimized", and same as Chrome does.

Comment 4

[Jan Henning [:JanH]]

With GeckoView all of this will be obsolete and need to be reimplemented anyway, but as the change is trivial...

Comment 5

[Jan Henning [:JanH]]

Attachment: Bug 1363049 - getNextTab() should only use parent tabs of the same type.

That is if the currently selected tab has a web app or custom tab as its "parent tab", we'll ignore that fact when the tab is closed from the tabs tray, so we don't trigger an activity switch that way.

Review commit: https://reviewboard.mozilla.org/r/140766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/140766/

Comment 6

[Julian Chu [:walkingice]]

Comment on attachment 8869133 [details]
Bug 1363049 - getNextTab() should only use parent tabs of the same type.

https://reviewboard.mozilla.org/r/140766/#review144536

Comment 7

[Jan Henning [:JanH]]

Comment on attachment 8869133 [details]
Bug 1363049 - getNextTab() should only use parent tabs of the same type.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/140766/diff/1-2/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f45828fef374
getNextTab() should only use parent tabs of the same type. r=walkingice

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f45828fef374

Comment 10

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 55 (2017-05-24)
Devices:
-Asus ZenPad 8.0 Z380KL (Android 6.0.1)
-Prestigio Grace X5 (Android 4.4.2)
-Huawei Honor 8 (Android 6.0)