Closed Bug 1363061 Opened 3 years ago Closed 2 years ago

Rename toolkit/components/jsdownloads to toolkit/components/downloads

Categories

(Toolkit :: Downloads API, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(1 file)

When bug 851471 is fixed, we should move the remaining files from toolkit/components/downloads to a folder for Application Reputation. When that is done, we can consider removing the "js" prefix from toolkit/components/jsdownloads.
Priority: -- → P3
The Application Reputation code has already been moved to a separate folder.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P3 → P1
Summary: Rename toolkit/components/downloads and toolkit/components/jsdownloads → Rename toolkit/components/jsdownloads to toolkit/components/downloads
I only renamed the folder here, and not the XPIDL component, because the name "downloads" is already used by the front-end component.
Er, actually, that was a leftover from the previous patch.
Comment on attachment 8956078 [details]
Bug 1363061 - Rename toolkit/components/jsdownloads to toolkit/components/downloads.

https://reviewboard.mozilla.org/r/225016/#review231340

I think you forgot to update this:
https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/testing/runtimes/mochitest-browser-chrome.runtimes.json#808

::: toolkit/components/build/moz.build:23
(Diff revision 2)
>  FINAL_LIBRARY = 'xul'
>  
>  LOCAL_INCLUDES += [
>      '../../xre',
>      '../alerts',
> +    '../downloads/src',

Either here, or in a follow-up, it would be nice to modernize/flatten the jsdownloads folder structure, as it has been done for other components.
Thus merge the contents of the public and src folders into the main folder and unify their moz.build files

obviously, as in the other cases, the test folder remains.
Attachment #8956078 - Flags: review?(mak77) → review+
I actually didn't open an issue for the not updated file, and since I know sometimes review comments get lost, I will point it out here, please check first part of comment 8.
(In reply to Marco Bonardo [::mak] from comment #8)
> I think you forgot to update this:
> https://searchfox.org/mozilla-central/rev/
> bffd3e0225b65943364be721881470590b9377c1/testing/runtimes/mochitest-browser-
> chrome.runtimes.json#808

That looked like a generated file so I didn't touch it, however I guess that adjusting the path won't hurt.

> Either here, or in a follow-up, it would be nice to modernize/flatten the
> jsdownloads folder structure, as it has been done for other components.

That's actually a very good idea and I can do this here to minimize the moves. Thanks!
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af5fa4cbcf26
Rename toolkit/components/jsdownloads to toolkit/components/downloads. r=mak
https://hg.mozilla.org/mozilla-central/rev/af5fa4cbcf26
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/47b4430bdfb6
Port bug 1363061 to TB/IB/SM: rename jsdownloads.xpt to downloads.xpt. rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.