Rename toolkit/components/jsdownloads to toolkit/components/downloads

RESOLVED FIXED in Firefox 60

Status

()

Toolkit
Downloads API
P1
normal
RESOLVED FIXED
a year ago
4 months ago

People

(Reporter: Paolo, Assigned: Paolo)

Tracking

unspecified
mozilla60
Points:
---

Firefox Tracking Flags

(firefox60 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
When bug 851471 is fixed, we should move the remaining files from toolkit/components/downloads to a folder for Application Reputation. When that is done, we can consider removing the "js" prefix from toolkit/components/jsdownloads.
(Assignee)

Updated

a year ago
Priority: -- → P3
(Assignee)

Comment 1

5 months ago
The Application Reputation code has already been moved to a separate folder.
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P3 → P1
Summary: Rename toolkit/components/downloads and toolkit/components/jsdownloads → Rename toolkit/components/jsdownloads to toolkit/components/downloads
Comment hidden (mozreview-request)
(Assignee)

Comment 4

5 months ago
I only renamed the folder here, and not the XPIDL component, because the name "downloads" is already used by the front-end component.
(Assignee)

Comment 5

5 months ago
Er, actually, that was a leftover from the previous patch.
Comment hidden (mozreview-request)

Comment 8

5 months ago
mozreview-review
Comment on attachment 8956078 [details]
Bug 1363061 - Rename toolkit/components/jsdownloads to toolkit/components/downloads.

https://reviewboard.mozilla.org/r/225016/#review231340

I think you forgot to update this:
https://searchfox.org/mozilla-central/rev/bffd3e0225b65943364be721881470590b9377c1/testing/runtimes/mochitest-browser-chrome.runtimes.json#808

::: toolkit/components/build/moz.build:23
(Diff revision 2)
>  FINAL_LIBRARY = 'xul'
>  
>  LOCAL_INCLUDES += [
>      '../../xre',
>      '../alerts',
> +    '../downloads/src',

Either here, or in a follow-up, it would be nice to modernize/flatten the jsdownloads folder structure, as it has been done for other components.
Thus merge the contents of the public and src folders into the main folder and unify their moz.build files

obviously, as in the other cases, the test folder remains.
Attachment #8956078 - Flags: review?(mak77) → review+

Comment 9

5 months ago
I actually didn't open an issue for the not updated file, and since I know sometimes review comments get lost, I will point it out here, please check first part of comment 8.
(Assignee)

Comment 10

5 months ago
(In reply to Marco Bonardo [::mak] from comment #8)
> I think you forgot to update this:
> https://searchfox.org/mozilla-central/rev/
> bffd3e0225b65943364be721881470590b9377c1/testing/runtimes/mochitest-browser-
> chrome.runtimes.json#808

That looked like a generated file so I didn't touch it, however I guess that adjusting the path won't hurt.

> Either here, or in a follow-up, it would be nice to modernize/flatten the
> jsdownloads folder structure, as it has been done for other components.

That's actually a very good idea and I can do this here to minimize the moves. Thanks!
Comment hidden (mozreview-request)

Comment 13

4 months ago
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af5fa4cbcf26
Rename toolkit/components/jsdownloads to toolkit/components/downloads. r=mak

Comment 14

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/af5fa4cbcf26
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox60: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60

Comment 15

4 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/47b4430bdfb6
Port bug 1363061 to TB/IB/SM: rename jsdownloads.xpt to downloads.xpt. rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.