Closed Bug 1363085 Opened 3 years ago Closed 3 years ago

Add telemetry, context menu, react-intl to Activity Stream system add-on

Categories

(Firefox :: New Tab Page, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: k88hudson, Assigned: k88hudson)

References

Details

(Whiteboard: [export])

Attachments

(2 files)

This patch will export our Telemetry-related and context menu code from Github to the Activity Stream system add-on.
Assignee: nobody → khudson
Priority: -- → P1
Will the license need to be updated now that we require react-intl and gets included in the bundle?

https://github.com/yahoo/react-intl/blob/master/LICENSE.md

I suppose similarly the vendor file should be part of the export?
Yes, we'll also need to update license.html and ask for review by gerv. Maybe we should split that out into another bug and block this one on it
Summary: Add telemetry, context menu to Activity Stream system add-on → Add telemetry, context menu, react-intl to Activity Stream system add-on
Comment on attachment 8865957 [details]
Bug 1363085 - Part 1. Update license for react-intl usage in activity-stream.

The react-intl repository page: https://github.com/yahoo/react-intl

says at the bottom: This software is free to use under the Yahoo Inc. BSD license. See the LICENSE file for license text and copyright information.

Links to: https://github.com/yahoo/react-intl/blob/master/LICENSE.md

The react-intl file doesn't exist yet, but will be added as part 2 of this bug. Also removes the reselect reference as we don't use it for the system-addon.
Attachment #8865957 - Flags: review?(gerv)
Comment on attachment 8865957 [details]
Bug 1363085 - Part 1. Update license for react-intl usage in activity-stream.

Apparently nevermind about removing reselect yet. The rest from comment 4 is good.
Attachment #8865957 - Flags: review?(gerv)
Comment on attachment 8866111 [details]
Bug 1363085 - Part 2. Add telemetry, context menu, react-intl to Activity Stream system add-on.

https://reviewboard.mozilla.org/r/137712/#review141088
Attachment #8866111 - Flags: review?(usarracini) → review+
Awesome, after Mardak's patch lands, I'll put up the release patch
Comment on attachment 8865957 [details]
Bug 1363085 - Part 1. Update license for react-intl usage in activity-stream.

https://reviewboard.mozilla.org/r/137552/#review141594
Attachment #8865957 - Flags: review?(gerv) → review+
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/08bb7fc6af84
Part 1. Update license for react-intl usage in activity-stream. r=gerv
https://hg.mozilla.org/integration/autoland/rev/13de8636a5de
Part 2. Add telemetry, context menu, react-intl to Activity Stream system add-on. r=ursula
Backed out for eslint failures, e.g. browser/extensions/activity-stream/test/unit/content-src/components/ContextMenu.test.js:13:

https://hg.mozilla.org/integration/autoland/rev/2d8bed0ba8d28036bdf131ad0ef5c763b6bbe225
https://hg.mozilla.org/integration/autoland/rev/5a935588f48497abf839e94b06508e4a762dcc19

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=13de8636a5deb05a360ead676d96b6ebf352e33f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=98434622&repo=autoland

[task 2017-05-11T16:51:07.559545Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/browser/extensions/activity-stream/test/unit/content-src/components/ContextMenu.test.js:13:29 | Parsing error: Unexpected token < (eslint)
[task 2017-05-11T16:51:07.559654Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/browser/extensions/activity-stream/test/unit/content-src/components/LinkMenu.test.js:9:31 | Parsing error: Unexpected token < (eslint)
[task 2017-05-11T16:51:07.559747Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/browser/extensions/activity-stream/test/unit/content-src/components/Search.test.js:18:37 | Parsing error: Unexpected token < (eslint)
[task 2017-05-11T16:51:07.559832Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/browser/extensions/activity-stream/test/unit/content-src/components/TopSites.test.js:13:29 | Parsing error: Unexpected token < (eslint)
Flags: needinfo?(edilee)
The component tests were renamed to .jsx to avoid linting.
Flags: needinfo?(edilee)
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/97c2f9bdb59f
Part 1. Update license for react-intl usage in activity-stream. r=gerv
https://hg.mozilla.org/integration/autoland/rev/020309d34751
Part 2. Add telemetry, context menu, react-intl to Activity Stream system add-on. r=ursula
Backed out for failing eslint, e.g. at browser/extensions/activity-stream/test/unit/content-src/components/ContextMenu.test.jsx:13 (jsx also gets linted):

https://hg.mozilla.org/integration/autoland/rev/9935a9f21a7c1a3a5ec50b9619afbd68ff429ff3
https://hg.mozilla.org/integration/autoland/rev/d43bcd2b7293a2d25a36bdcedf7036f32a8ba385

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=020309d347513383c22c65c266ba035144139264&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=98454659&repo=autoland

[task 2017-05-11T18:05:33.674450Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/browser/extensions/activity-stream/test/unit/content-src/components/ContextMenu.test.jsx:13:29 | Parsing error: Unexpected token < (eslint)
[task 2017-05-11T18:05:33.674567Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/browser/extensions/activity-stream/test/unit/content-src/components/LinkMenu.test.jsx:9:31 | Parsing error: Unexpected token < (eslint)
[task 2017-05-11T18:05:33.674646Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/browser/extensions/activity-stream/test/unit/content-src/components/Search.test.jsx:18:37 | Parsing error: Unexpected token < (eslint)
[task 2017-05-11T18:05:33.674734Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/browser/extensions/activity-stream/test/unit/content-src/components/TopSites.test.jsx:13:29 | Parsing error: Unexpected token < (eslint)
Flags: needinfo?(edilee)
Meh meh meh. Locally the .jsx files didn't get linted. Not sure why our pine treeherder isn't running eslint either. I'll take a closer look at this today.

Simple fix is to just not land the tests as they aren't being run anyway.
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ecfb960dc109
Part 1. Update license for react-intl usage in activity-stream. r=gerv
https://hg.mozilla.org/integration/autoland/rev/cd1987f0ceec
Part 2. Add telemetry, context menu, react-intl to Activity Stream system add-on. r=ursula
https://hg.mozilla.org/mozilla-central/rev/ecfb960dc109
https://hg.mozilla.org/mozilla-central/rev/cd1987f0ceec
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Blocks: 1368775
Depends on: 1359481
Whiteboard: [export]
Component: Activity Streams: General → Activity Streams: Newtab
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.