1363173 - Update openvr to build with MinGW

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Description

[Tom Ritter [:tjr]]

openvr causes several errors with MinGW. this patch fixes all of them I have found so far.

These have been submitted upstream:
https://github.com/ValveSoftware/openvr/pull/508
https://github.com/ValveSoftware/openvr/pull/509
https://github.com/ValveSoftware/openvr/pull/510
https://github.com/ValveSoftware/openvr/pull/511

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1363173 Update OpenVR to build with MinGW

This involved four commits:
- Windows.h -> windows.h and similar https://github.com/ValveSoftware/openvr/pull/508
- Add a void* cast for a farproc auto-conversion https://github.com/ValveSoftware/openvr/pull/509
- Add share.h https://github.com/ValveSoftware/openvr/pull/510
- Use GCC Variadic Macros https://github.com/ValveSoftware/openvr/pull/511

Review commit: https://reviewboard.mozilla.org/r/137238/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137238/

Comment 2

[Tom Ritter [:tjr]]

Hey Kip - is this something we'd consider taking for now, since OpenVR indicated they would upstream them so they shouldn't get lost or have to be maintained?

Comment 3

[:kip (Kearwood Gilbert)]

(In reply to Tom Ritter [:tjr] from comment #2)
> Hey Kip - is this something we'd consider taking for now, since OpenVR
> indicated they would upstream them so they shouldn't get lost or have to be
> maintained?

Yes, we can certainly take them and apply to m-c.

I've reviewed the patch, and it looks good, thanks!

Comment 4

[:kip (Kearwood Gilbert)]

Comment on attachment 8865611 [details]
Bug 1363173 Update OpenVR to build with MinGW

https://reviewboard.mozilla.org/r/137238/#review146162

This looks good.  We can take this in m-c before it lands upstream in OpenVR's github repo.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d867f09f117
Update OpenVR to build with MinGW r=kip

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4d867f09f117