Avoid doing unneeded work in nsContentBlocker when no permissions for the content type are present

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Ehsan, Assigned: Nika)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
See bug 1357107 comment 25.

Michael, are you interested to write a patch?  :-)
Flags: needinfo?(michael)
(Reporter)

Updated

2 years ago
Blocks: 1347376
(Assignee)

Comment 1

2 years ago
Created attachment 8866386 [details] [diff] [review]
Avoid checking nsPermissionManager in nsContentBlocker when no preload permissions are set

MozReview-Commit-ID: B8A8QXie8SX
Attachment #8866386 - Flags: review?(ehsan)
(Assignee)

Updated

2 years ago
Assignee: nobody → michael
Flags: needinfo?(michael)
(Reporter)

Comment 2

2 years ago
Comment on attachment 8866386 [details] [diff] [review]
Avoid checking nsPermissionManager in nsContentBlocker when no preload permissions are set

Review of attachment 8866386 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks a lot!
Attachment #8866386 - Flags: review?(ehsan) → review+

Comment 3

2 years ago
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db4d4ed118a5
Avoid checking nsPermissionManager in nsContentBlocker when no preload permissions are set, r=ehsan

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/db4d4ed118a5
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.