Closed
Bug 1363291
Opened 7 years ago
Closed 7 years ago
[jsplugins] Handle save to file when printing pdf without e10s failed
Categories
(Firefox :: General, enhancement)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: lochang, Assigned: lochang)
Details
Attachments
(1 file)
We will access the file path by giving the key "ContentTmpD", but it's only work on content process. On non-e10s we can't save pdf to file now.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
Hi Bruce, Could you please review the patch? Thanks. Since the file path we retrieve from key Tmpd is different between content process and jsplugin process, we pass the absolute path from jsplugin process to content process instead of the key and file name. Also it seems no one is using contentTmpD in script file so we change it to TmpD on all platform.
| Comment hidden (mozreview-request) |
|
||
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8867588 [details] Bug 1363291 - Handle save to file when printing pdf in non-e10s. https://reviewboard.mozilla.org/r/139138/#review142380 LGTM
Attachment #8867588 -
Flags: review?(brsun) → review+
Pushed by brsun@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2eea6d27f05f Handle save to file when printing pdf in non-e10s. r=brsun
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2eea6d27f05f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in
before you can comment on or make changes to this bug.
Description
•