[jsplugins] Handle save to file when printing pdf without e10s failed

RESOLVED FIXED in Firefox 55

Status

()

Firefox
General
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: louis, Assigned: louis)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We will access the file path by giving the key "ContentTmpD", but it's only work on content process. On non-e10s we can't save pdf to file now.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

11 months ago
Hi Bruce,

Could you please review the patch? Thanks.

Since the file path we retrieve from key Tmpd is different between content process and jsplugin process, we pass the absolute path from jsplugin process to content process instead of the key and file name. Also it seems no one is using contentTmpD in script file so we change it to TmpD on all platform.
Comment hidden (mozreview-request)

Comment 4

11 months ago
mozreview-review
Comment on attachment 8867588 [details]
Bug 1363291 - Handle save to file when printing pdf in non-e10s.

https://reviewboard.mozilla.org/r/139138/#review142380

LGTM
Attachment #8867588 - Flags: review?(brsun) → review+

Comment 5

11 months ago
Pushed by brsun@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2eea6d27f05f
Handle save to file when printing pdf in non-e10s. r=brsun

Comment 6

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2eea6d27f05f
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.