Closed Bug 1363305 Opened 9 years ago Closed 9 years ago

SVGContextPaint::Init should not return image::DrawResult values

Categories

(Core :: SVG, enhancement)

Product:
Core
Component:
SVG
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: jwatt, Assigned: u459114)

References

Details

It seem like SVGContextPaint::Init should not return image::DrawResult values. We should follow the code through to see if an DrawResult even needs to be returned at all (are we actually doing drawing under that call, or only setting up for later painting?), but if so then it should be as an imgDrawingParams parameter (being added in bug 1351440), not a return value.
I already fixed it in "Bug 1351440 - Part 4. Pass imgDrawingParams to .."
Ah, sweet. Thanks!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee: nobody → cku
status-firefox55: --- → fixed
status-firefox57: affected → ---
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.