1363403 - Facebook profile navigation start: access the user photo profile from a post

Status: NEW

(Core :: JavaScript Engine, defect, P3)

Description

[Alin Rus]

Name: Firefox
Version: 55.0a1
Windows 10 64 bit
buildID: 20170508030204

Steps to reproduce:
1. Launch browser.
2. Fill Facebook.com in Navigation Start, then press enter.
3. Login with credentials.
4. Record with Gecko Profile:
   Tap on a user photo profile from first post you have displayed.
5. Share the profile.

Gecko profile:
https://perfht.ml/2q0k3mJ

Notes:
https://docs.google.com/spreadsheets/d/1Kxn850VasyaG_WfRg3pMInW0hbIT8LP7pRPBYTIpdbM/edit?pli=1#gid=679575660

Comment 1

[Alin Rus]

https://perfht.ml/2rlP3yz
Here's the Gecko profile obtained on Acer Aspire e15.
Version: 55.0a1
Windows 10 64 bit
buildID: 20170518030213

Comment 2

[Alin Rus]

Please take in consideration only this profile obtained on Acer Aspire e15, the above one is not accurate: https://perfht.ml/2q0e1zC

Comment 3

[Jean Gong :jgong]

David, please do an analysis on the profile listed in comment 2. Thanks,Jean

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

This profile is almost exclusively in JS. It looks like we're stuck in the interpreter calling into fun_apply where the target is also interpreted. I don't know whether this function is supposed to be JIT'd or not, but speculatively assigning to the JS: JIT component.

Comment 5

[Naveed Ihsanullah [:naveed]]

Kannan can you please take a look at this one?

Comment 6

[Kannan Vijayan [:djvj]]

It doesn't seem like this is a jittable case.  Looking down the JS trace, all the Function.apply calls are happening at different locations in the source code.  Given that the repro steps involve loading the page fresh, and then performing the user photo profile.. I'm expecting that this is cold code.

We can't get this into the JIT, I suspect.  The quick-but-unsatisfying answer based on the above reasoning is just "make the interpreter faster".

Comment 7

[Ionut Budeanu]

Updating the Gecko Profile based on the latest benchmark measurements.

Name: Firefox
Version: 57.0a1
Windows 10 64 bit
buildID: 20170910220126


Gecko Profile: https://perfht.ml/2w1a58P

Comment 8

[Jean Gong :jgong]

This bug won't be address within 57; I am changing it from qf:p1 to qf:p3 for post 57 work.

Comment 9

[Nicolas B. Pierron [:nbp]]

(In reply to Kannan Vijayan [:djvj] from comment #6)
> It doesn't seem like this is a jittable case.  Looking down the JS trace,
> all the Function.apply calls are happening at different locations in the
> source code.  Given that the repro steps involve loading the page fresh, and
> then performing the user photo profile.. I'm expecting that this is cold
> code.
> 
> We can't get this into the JIT, I suspect.  The quick-but-unsatisfying
> answer based on the above reasoning is just "make the interpreter faster".