1363473 - Remove typedefs from GLContextSymbols.h

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P4)

Comment 1

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8866009 [details] [diff] [review]
0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch

Review of attachment 8866009 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextSymbols.h
@@ +31,4 @@
>          Zero();
>      }
>  
> +   void Zero() {

This lost a space of indent for some reason.

@@ +56,5 @@
> +    void (GLAPIENTRY * fClearBufferiv)(GLenum, GLint, const GLint*);
> +    void (GLAPIENTRY * fClearBufferuiv)(GLenum, GLint, const GLuint*);
> +    void (GLAPIENTRY * fClearColor)(GLfloat, GLfloat, GLfloat, GLfloat);
> +    void (GLAPIENTRY * fClearStencil)(GLint);
> +    void (GLAPIENTRY * fColorMask)(realGLboolean, realGLboolean, realGLboolean, 

End of line whitespace.

@@ +285,3 @@
>  
>      // ARB_copy_buffer / OpenGL 3.1 / OpenGL ES 3.0
> +    void (GLAPIENTRY * fCopyBufferSubData)(GLenum, GLenum ,

Remove the spaces before the commas here.

@@ +322,5 @@
> +    void (GLAPIENTRY * fDeleteTransformFeedbacks)(GLsizei, const GLuint*);
> +     realGLboolean (GLAPIENTRY * fIsTransformFeedback)(GLuint);
> +    void (GLAPIENTRY * fBindTransformFeedback)(GLenum, GLuint);
> +    void (GLAPIENTRY * fTransformFeedbackVaryings)(GLuint, GLsizei, const GLchar* 
> +                                                   const*, GLenum);

You've split a type across lines here:
`const GLChar* const*` is one type

@@ +389,4 @@
>  
>      // uniform_buffer_object
> +    void (GLAPIENTRY * fGetUniformIndices)(GLuint, GLsizei , const GLchar* 
> +                                           const*, GLuint*);

`const GLchar* const*` on one line

Comment 3

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch

Comment 4

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8866029 [details] [diff] [review]
0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch

Review of attachment 8866029 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContextSymbols.h
@@ +285,4 @@
>  
>      // ARB_copy_buffer / OpenGL 3.1 / OpenGL ES 3.0
> +    void (GLAPIENTRY * fCopyBufferSubData)(GLenum, GLenum,
> +                                            GLintptr, GLintptr,

This indentation is misaligned.

@@ +368,3 @@
>  
>      // map_buffer_range
> +    void* (GLAPIENTRY *  fMapBufferRange)(GLenum, GLintptr, GLsizeiptr, GLbitfield);

s/ [*] +/ * /g

@@ +421,5 @@
> +   void (GLAPIENTRY * fTexImage3D)(GLenum, GLint, GLenum, GLenum, GLsizei, GLsizei,
> +                                   GLint, GLenum, GLenum, const GLvoid*);
> +
> +   void (GLAPIENTRY * fTexSubImage3D)(GLenum, GLint, GLint, GLint, GLint, GLsizei,
> +                                       GLsizei, GLsizei, GLenum, GLenum, const GLvoid*);

Misaligned, here and below.

Comment 5

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch

Comment 6

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch

Comment 7

[Carsten Book [:Tomcat]]

needs rebasing

Fetching... done
Parsing... done
adding 1363473 to series file
renamed 1363473 -> 0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch
applying 0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch
patching file gfx/gl/GLContextSymbols.h
Hunk #1 FAILED at 26
1 out of 1 hunks FAILED -- saving rejects to file gfx/gl/GLContextSymbols.h.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch

Comment 8

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch

Comment 9

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1363473-Remove-typedefs-from-GLContextSymbols.h-.patch

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e518d6c45bf
Remove typedefs from GLContextSymbols.h - r=jgilbert

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6e518d6c45bf