1363497 - Expose react-addons-perf from console launchpad

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Brian Grinstead [:bgrins]]

This only works with the dev version of react, but we can add a new npm command to explicitly use dev, and make npm start use prod by default.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1363497 - Include react-addons-perf for launchpad via `npm run dev`;

Review commit: https://reviewboard.mozilla.org/r/137632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137632/

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8866033 [details]
Bug 1363497 - Include react-addons-perf for launchpad via `npm run dev`;

https://reviewboard.mozilla.org/r/137632/#review140976

Just a small nit but this looks good to me

::: devtools/client/webconsole/package.json:9
(Diff revision 1)
>    "engines": {
>      "node": ">=6.9.0"
>    },
>    "scripts": {
> -    "start": "node bin/dev-server",
> +    "start": "cross-env NODE_ENV=production node bin/dev-server",
> +    "dev": "node bin/dev-server",

nit: What do you think of naming this `start-dev` or something alike, so it looks like the original start command ?

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8866033 [details]
Bug 1363497 - Include react-addons-perf for launchpad via `npm run dev`;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137632/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e204f93b4a39
Include react-addons-perf for launchpad via `npm run dev`;r=nchevobbe

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e204f93b4a39