Expose react-addons-perf from console launchpad

RESOLVED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Console
P1
normal
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [console-html])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
This only works with the dev version of react, but we can add a new npm command to explicitly use dev, and make npm start use prod by default.
Comment hidden (mozreview-request)

Updated

7 months ago
Iteration: --- → 55.5 - May 15
Flags: qe-verify?
Priority: -- → P1

Comment 2

7 months ago
mozreview-review
Comment on attachment 8866033 [details]
Bug 1363497 - Include react-addons-perf for launchpad via `npm run dev`;

https://reviewboard.mozilla.org/r/137632/#review140976

Just a small nit but this looks good to me

::: devtools/client/webconsole/package.json:9
(Diff revision 1)
>    "engines": {
>      "node": ">=6.9.0"
>    },
>    "scripts": {
> -    "start": "node bin/dev-server",
> +    "start": "cross-env NODE_ENV=production node bin/dev-server",
> +    "dev": "node bin/dev-server",

nit: What do you think of naming this `start-dev` or something alike, so it looks like the original start command ?
Attachment #8866033 - Flags: review?(nchevobbe) → review+
Comment hidden (mozreview-request)

Comment 4

7 months ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e204f93b4a39
Include react-addons-perf for launchpad via `npm run dev`;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/e204f93b4a39
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Updated

7 months ago
Flags: qe-verify? → qe-verify-
You need to log in before you can comment on or make changes to this bug.