Revert .App rewriting from Bug 1320310 to restore Android Studio launch experience for local{Old} configurations

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1320310#c14, the fix for Bug 1320310 interferes with the Android Studio launch experience.  This ticket tracks reverting that change for non-official audiences.
Comment hidden (mozreview-request)
I thought this was only a problem if you had imported the project into Android Studio with the old code - and after fixing the run configuration or on new import this problem is gone?
(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> I thought this was only a problem if you had imported the project into
> Android Studio with the old code - and after fixing the run configuration or
> on new import this problem is gone?

I was not aware that this was an issue with old state not being correctly migrated; I thought the issue was that problem AS fishes the intent to launch from the manifest before it's processed and not after the <intent-filter> has been rewritten.

I don't have time to test this now, but if somebody could do a clean import (after removing **/.idea throughout the tree) I'd appreciate more information.

Comment 4

2 years ago
mozreview-review
Comment on attachment 8866057 [details]
Bug 1363526 - Revert .App rewriting to restore Android Studio launch for developers.

https://reviewboard.mozilla.org/r/137650/#review142216
Attachment #8866057 - Flags: review?(max) → review+
(In reply to Nick Alexander :nalexander from comment #3)
> (In reply to Sebastian Kaspari (:sebastian) from comment #2)
> > I thought this was only a problem if you had imported the project into
> > Android Studio with the old code - and after fixing the run configuration or
> > on new import this problem is gone?
> 
> I was not aware that this was an issue with old state not being correctly
> migrated; I thought the issue was that problem AS fishes the intent to
> launch from the manifest before it's processed and not after the
> <intent-filter> has been rewritten.
> 
> I don't have time to test this now, but if somebody could do a clean import
> (after removing **/.idea throughout the tree) I'd appreciate more
> information.

Nobody got to this, and I couldn't work around it locally, so I'm landing the patch.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED

Comment 6

2 years ago
Pushed by nalexander@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c84d03ca612e
Revert .App rewriting to restore Android Studio launch for developers. r=maliu
https://hg.mozilla.org/mozilla-central/rev/c84d03ca612e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.