1363526 - Revert .App rewriting from Bug 1320310 to restore Android Studio launch experience for local{Old} configurations

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1320310#c14, the fix for Bug 1320310 interferes with the Android Studio launch experience.  This ticket tracks reverting that change for non-official audiences.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1363526 - Revert .App rewriting to restore Android Studio launch for developers.

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1320310#c14, the fix
for Bug 1320310 interferes with the Android Studio launch experience.
This reverts that change for non-official audiences, i.e., the
local{Old} configurations used by developers.

Review commit: https://reviewboard.mozilla.org/r/137650/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137650/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

I thought this was only a problem if you had imported the project into Android Studio with the old code - and after fixing the run configuration or on new import this problem is gone?

Comment 3

[Nick Alexander :nalexander [he/him]]

(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> I thought this was only a problem if you had imported the project into
> Android Studio with the old code - and after fixing the run configuration or
> on new import this problem is gone?

I was not aware that this was an issue with old state not being correctly migrated; I thought the issue was that problem AS fishes the intent to launch from the manifest before it's processed and not after the <intent-filter> has been rewritten.

I don't have time to test this now, but if somebody could do a clean import (after removing **/.idea throughout the tree) I'd appreciate more information.

Comment 4

[Max Liu [:maliu]]

Comment on attachment 8866057 [details]
Bug 1363526 - Revert .App rewriting to restore Android Studio launch for developers.

https://reviewboard.mozilla.org/r/137650/#review142216

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Nick Alexander :nalexander from comment #3)
> (In reply to Sebastian Kaspari (:sebastian) from comment #2)
> > I thought this was only a problem if you had imported the project into
> > Android Studio with the old code - and after fixing the run configuration or
> > on new import this problem is gone?
> 
> I was not aware that this was an issue with old state not being correctly
> migrated; I thought the issue was that problem AS fishes the intent to
> launch from the manifest before it's processed and not after the
> <intent-filter> has been rewritten.
> 
> I don't have time to test this now, but if somebody could do a clean import
> (after removing **/.idea throughout the tree) I'd appreciate more
> information.

Nobody got to this, and I couldn't work around it locally, so I'm landing the patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c84d03ca612e
Revert .App rewriting to restore Android Studio launch for developers. r=maliu

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c84d03ca612e