1363573 - stylo: Combine ComputeDuration and Interpolate into a single trait

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P1)

Description

[Brian Birtles (:birtles)]

Splitting this off from bug 1329878 since it will bitrot quickly.

Comment 1

[Brian Birtles (:birtles)]

Attachment: Bug 1363573 - Rename the Interpolate trait to Animatable;

We intend to extend this trait to include a number of animation-related
functions.

Review commit: https://reviewboard.mozilla.org/r/137786/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137786/

Comment 2

[Brian Birtles (:birtles)]

Attachment: Bug 1363573 - Merge ComputeDistance trait into Animatable trait;

Review commit: https://reviewboard.mozilla.org/r/137788/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137788/

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8866175 [details]
Bug 1363573 - Rename the Interpolate trait to Animatable;

https://reviewboard.mozilla.org/r/137786/#review140936

Here is another Interpolate;
servo/tests/unit/style/animated_properties.rs

Comment 4

[Brian Birtles (:birtles)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #3)
> Comment on attachment 8866175 [details]
> Bug 1363573 - Rename the Interpolate trait to Animatable;
> 
> https://reviewboard.mozilla.org/r/137786/#review140936
> 
> Here is another Interpolate;
> servo/tests/unit/style/animated_properties.rs

Nice, thanks!

Comment 5

[Brian Birtles (:birtles)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5b2196693562d7202c288c20ef0998497f1840f

It turns out I wrote these patches on a checkout from a couple of weeks ago. I hope I didn't break anything when rebasing.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8866176 [details]
Bug 1363573 - Merge ComputeDistance trait into Animatable trait;

https://reviewboard.mozilla.org/r/137788/#review140942

Comment 7

[Brian Birtles (:birtles)]

Attachment: Servo PR #16792

Comment 8

[Hiroyuki Ikezoe (:hiro)]

https://hg.mozilla.org/mozilla-central/rev/e595d2a6c7f8

Comment 9

[Anthony Ramine [:nox]]

Why were these two traits merged together? I can't find an explanation as to what this gives us.