1363614 - Crash in mozalloc_abort | NS_DebugBreak | mozilla::ipc::LogicError | mozilla::dom::PBrowser::Transition

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Ting-Yu Chou [:ting] (away)]

This bug was filed from the Socorro interface and is 
report bp-78066d4e-5172-4875-8ae3-149000170509.
=============================================================
Top #18 of Nightly 20170507030205 on Windows, 10 reports form 5 installations.

Comment 1

[(no longer active)]

The crashes are happening because the actor is dead.  I think we should avoid doing the IPC calls in that case.

Comment 2

[(no longer active)]

Attachment: Don't attempt to notify the parent about the change in the number of beforeunload event listeners if our IPC link is already severed

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8866188 [details] [diff] [review]
Don't attempt to notify the parent about the change in the number of beforeunload event listeners if our IPC link is already severed

Review of attachment 8866188 [details] [diff] [review]:
-----------------------------------------------------------------

Seems kinda strange that the IPC Actor parent classes wouldn't just do this internally, but okay.

Comment 4

[(no longer active)]

Oh, this is a very normal type of crash, our IPC layer has no protection against anything if you call into it after an actor gets destroyed.  If you aren't careful you can easily end up in the Transition() function in a place like this: <https://searchfox.org/mozilla-central/source/__GENERATED__/ipc/ipdl/PBrowser.cpp#34> which is what's happening here.  :-)

(I really wish our IPC layer would protect us against this, I'm sick of fixing crashes like this honestly!)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d9aa3c7ea030
Don't attempt to notify the parent about the change in the number of beforeunload event listeners if our IPC link is already severed; r=mconley

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d9aa3c7ea030