[DateTimePicker] Add step support to date picker

RESOLVED FIXED in Firefox 56

Status

()

Core
Layout: Form Controls
P1
normal
RESOLVED FIXED
9 months ago
6 months ago

People

(Reporter: scottwu, Assigned: scottwu)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
Support the step property for date picker. Dates should be disabled if they are off-step, as shown in the UX spec: https://mozilla.invisionapp.com/share/237UTNHS8#/screens/171579745
Comment hidden (mozreview-request)
(Assignee)

Comment 2

9 months ago
Implemented step for the calendar view. Step feature for month and year spinners has been de-scoped.

In this patch, the `getDays` function in `datekeeper.js` has been re-arranged, and "selection" state would not be applied if the date is either out-of-range or off-step.
Comment on attachment 8866709 [details]
Bug 1363672 - Add step support to date picker.

https://reviewboard.mozilla.org/r/138334/#review143182

This looks great! Thanks!
Attachment #8866709 - Flags: review?(mconley) → review+
(Assignee)

Comment 4

8 months ago
Thanks Mike, I've since found a few issues with how min/max/value are handled in this patch, so I'll delay landing this patch for now.
Priority: -- → P1
Comment hidden (mozreview-request)
(Assignee)

Comment 6

6 months ago
Updated the patch to use `getStep` and `getStepBase` which are used by input fields to calculate steps. This simplifies things because the picker wouldn't need to do the same calculation when input field also did. Aside from that, nothing is changed. I think it's safe to check this in.
Keywords: checkin-needed

Comment 7

6 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f7afd5fee9f2
Add step support to date picker. r=mconley
Keywords: checkin-needed

Comment 8

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f7afd5fee9f2
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.