Closed
Bug 1363675
Opened 8 years ago
Closed 8 years ago
Get D3D11Device from TextureSourceProvider if it exists.
Categories
(Core :: Graphics: Layers, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: vliu, Assigned: vliu)
References
Details
Attachments
(1 file)
|
1.41 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
This bug was created since from a look into bug 1362366. The detail can see bug 1362366 Comment 5. Since the fix of this bug probably not fixing bug 1362366, I decided open this one ans see *see also* to that one.
|
Assignee | |
Comment 1•8 years ago
|
||
Hi David,
Could you please have a review? Really thanks.
Attachment #8866284 -
Flags: review?(dvander)
Comment on attachment 8866284 [details] [diff] [review]
0001-Bug-1363675-Get-D3D11Device-from-TextureSourceProvid.patch
Review of attachment 8866284 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good. It looks like this release assertion will fire if we attempt to upload a buffer, or composite to, a texture attached to a dead compositor. After bug 1363126 I would expect this to be nearly impossible to hit, so if it does, we should have some very interesting feedback.
Attachment #8866284 -
Flags: review?(dvander) → review+
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → vliu
|
|
Assignee | |
Comment 3•8 years ago
|
||
Pushed by vliu@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8cfb113ea73b
Get D3D11Device from TextureSourceProvider if it exists. r=dvander
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•