Closed Bug 1363676 Opened 3 years ago Closed 3 years ago

Use Variant as the internal storage of ResolveOrRejectValue

Categories

(Core :: XPCOM, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(2 files)

This kinda optimize the storage usage.
Assignee: nobody → jwwang
Blocks: 1362910
Priority: -- → P3
You stole my idea! :-)
You'll need to wait for bug 1338389, as some Resolve & Reject types are the same in existing code.
Depends on: 1338389
I will use some tricks to work around it so this bug and bug 1362910 can continue. We can remove the tricks after bug 1338389 is fixed.
Attachment #8866286 - Flags: review?(gsquelart)
Attachment #8866287 - Flags: review?(gsquelart)
Comment on attachment 8866286 [details]
Bug 1363676. P1 - use Variant as the internal storage of ResolveOrRejectValue.

https://reviewboard.mozilla.org/r/137904/#review141020

Clever!
Attachment #8866286 - Flags: review?(gsquelart) → review+
Comment on attachment 8866287 [details]
Bug 1363676. P2 - add a gtest to ensure we don't break ResolveOrRejectValue during refactoring.

https://reviewboard.mozilla.org/r/137906/#review141022
Attachment #8866287 - Flags: review?(gsquelart) → review+
Well played, you don't actually need bug 1338389! (But I'm hoping it will simplify this code soon...)
No longer depends on: 1338389
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5fb3ab3d4ce8
P1 - use Variant as the internal storage of ResolveOrRejectValue. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9547fbdccbed
P2 - add a gtest to ensure we don't break ResolveOrRejectValue during refactoring. r=gerald
https://hg.mozilla.org/mozilla-central/rev/5fb3ab3d4ce8
https://hg.mozilla.org/mozilla-central/rev/9547fbdccbed
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.