1363676 - Use Variant as the internal storage of ResolveOrRejectValue

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

This kinda optimize the storage usage.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

You stole my idea! :-)
You'll need to wait for bug 1338389, as some Resolve & Reject types are the same in existing code.

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

I will use some tricks to work around it so this bug and bug 1362910 can continue. We can remove the tricks after bug 1338389 is fixed.

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1363676. P1 - use Variant as the internal storage of ResolveOrRejectValue.

Review commit: https://reviewboard.mozilla.org/r/137904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137904/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1363676. P2 - add a gtest to ensure we don't break ResolveOrRejectValue during refactoring.

Review commit: https://reviewboard.mozilla.org/r/137906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137906/

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8866286 [details]
Bug 1363676. P1 - use Variant as the internal storage of ResolveOrRejectValue.

https://reviewboard.mozilla.org/r/137904/#review141020

Clever!

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8866287 [details]
Bug 1363676. P2 - add a gtest to ensure we don't break ResolveOrRejectValue during refactoring.

https://reviewboard.mozilla.org/r/137906/#review141022

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Well played, you don't actually need bug 1338389! (But I'm hoping it will simplify this code soon...)

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5fb3ab3d4ce8
P1 - use Variant as the internal storage of ResolveOrRejectValue. r=gerald
https://hg.mozilla.org/integration/autoland/rev/9547fbdccbed
P2 - add a gtest to ensure we don't break ResolveOrRejectValue during refactoring. r=gerald

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5fb3ab3d4ce8
https://hg.mozilla.org/mozilla-central/rev/9547fbdccbed