Closed Bug 1363679 Opened 7 years ago Closed 3 years ago

Standardize zoom levels for zooming website page content by various methods

Categories

(Firefox :: Toolbars and Customization, enhancement, P3)

x86_64
Windows 7
enhancement

Tracking

()

RESOLVED WONTFIX

People

(Reporter: Virtual, Unassigned)

Details

(4 keywords)

Zooming with Zoom Controls button in hamburger menu is inconsistent with zooming with Mouse Scroll.

These zoom levels are missing:
- 40%
- 60%
- 70%
- 130%
- 140%
- 160%
- 180%
- 190%
- 210%
- 220%
- 230%
- 250%
- 260%
- 270%
- 280%
- 290%
...using Zoom Controls button in hamburger menu, instead of Mouse Scroll.

Instead, there are some odd values, like:
- 76%
- 133%


So when users don't have mouse with scroll, they loose massive amount of zoom control.



Zoom with mouse scroll:
- 30%
- 40%
- 50%
- 60%
- 70%
- 80%
- 90%
- 100% (default)
- 110%
- 120%
- 130%
- 140%
- 150%
- 160%
- 170%
- 180%
- 190%
- 200%
- 210%
- 220%
- 230%
- 240%
- 250%
- 260%
- 270%
- 280%
- 290%
- 300%

Zoom with Zoom Controls button in hamburger menu:
- 30%
- 50%
- 76%
- 80%
- 90%
- 100% (default)
- 110%
- 120%
- 133%
- 150%
- 170%
- 200%
- 240%
- 300%
@ :Gijs - Could it be blocking one of the Proton bugs, like: bug #1354105 or bug #1359625?
Has Regression Range: --- → irrelevant
Has STR: --- → yes
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Virtual_ManPL [:Virtual] - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #1)
> @ :Gijs - Could it be blocking one of the Proton bugs, like: bug #1354105 or
> bug #1359625?

I don't think it should right now. We won't get rid of the existing control. It'll be in the palette (toolbox) by default, and the fixed hamburger menu will have a similar item but it will need its own implementation. I expect the new thing will piggyback on the old code and/or the existing zoom in/out stuff, but I don't know for sure. Either way, even if we use the same stops in the new control as we use for mouse scroll, we would still need to fix the old control. I don't know *why* the zoom stops are different today, and if it's easy to fix or not, so I am hesitant to say we should "just" do that as part of Photon, too. We have a lot of work as it is.

You could add a comment to bug 1354105 to say that if it's easy to do, we should not re-create this bug when creating the new panel zoom controls.

Out of curiosity, does the same bug exist for the keyboard controls and/or menu items in (menubar) View > Zoom ? I would kind of expect that to be the case, but I don't know for sure.
Flags: needinfo?(gijskruitbosch+bugs) → needinfo?(Virtual)
(In reply to :Gijs from comment #2)
> I don't think it should right now [...]
> so I am hesitant to say we should "just" do that
> as part of Photon, too. We have a lot of work as it is.

OK. Thank you very much for reply.


> You could add a comment to bug 1354105 to say that if it's easy to do, we
> should not re-create this bug when creating the new panel zoom controls.

I will post information there about this bug.


(In reply to :Gijs from comment #2)
> Out of curiosity, does the same bug exist for the keyboard controls and/or
> menu items in (menubar) View > Zoom ? I would kind of expect that to be the
> case, but I don't know for sure.

Unfortunately, yes. I added this information to bug topic.
Flags: needinfo?(Virtual)
Summary: Zooming with Zoom Controls button in hamburger menu is inconsistent with zooming with Mouse Scroll → Zooming with: +/- Zoom Controls buttons in hamburger menu, Zoom In/Out buttons in Menu Bar in View menu in Zoom submenu, Ctrl + +/- keyboard shortcuts; - are inconsistent with zooming with Mouse Scroll
Summary: Zooming with: +/- Zoom Controls buttons in hamburger menu, Zoom In/Out buttons in Menu Bar in View menu in Zoom submenu, Ctrl + +/- keyboard shortcuts; - are inconsistent with zooming with Mouse Scroll → Zooming with: +/- Zoom Controls buttons in hamburger menu, Zoom In/Out buttons in Menu Bar in View menu in Zoom submenu, Ctrl + +/- keyboard shortcuts; - are inconsistent with zooming with Ctrl + Mouse Scroll
Summary: Zooming with: +/- Zoom Controls buttons in hamburger menu, Zoom In/Out buttons in Menu Bar in View menu in Zoom submenu, Ctrl + +/- keyboard shortcuts; - are inconsistent with zooming with Ctrl + Mouse Scroll → Standardize zoom levels for zooming website page content by various methods

I managed to reproduce this on Firefox Nightly 95.0a1, Firefox Beta 94.0b4 and on Firefox 93.0 on Windows 10 x64, macOS 11.4 and on Ubuntu 20.04.

Severity: major → S3

Pinch zoom now means that there are effectively an infinite number of zoom levels for touchpad-based zoom, so full consistency seems hard to achieve. I don't think that spending energy on this is likely to provide meaningful benefits to end users. If people care, they can adjust toolkit.zoomManager.zoomValues in about:config.

Severity: S3 → S4
Status: NEW → RESOLVED
Type: defect → enhancement
Closed: 3 years ago
Priority: -- → P3
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.