1363681 - Move the network update information outside of the message type

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

We could have a proper entry in the store (networkInformationById or something alike) instead of replacing the whole message object.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1363681 - Move the network update information outside of the message type.

This moves network update messages to their own property on the store.
We take this as an opportunity to only dispatch the last network update,
i.e. `eventTimings` since it has all we need and saves us some time (there
are 8 network update per network messages, which can be costly).

Review commit: https://reviewboard.mozilla.org/r/146160/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146160/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8874780 [details]
Bug 1363681 - Move the network update information outside of the message type.

https://reviewboard.mozilla.org/r/146160/#review150168

Looks reasonable to me!

R+ assuming try is green

Honza

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

TRY is fine https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e3e800c650fde9821ef8c7e1877a4662d1a1a07

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/949533a9e987
Move the network update information outside of the message type. r=Honza

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/949533a9e987