59 bytes, text/x-review-board-request
+++ This bug was initially created as a clone of Bug #1361418 +++ https://dxr.mozilla.org/mozilla-central/rev/b21b974d60d3075ae24f6fb1bae75d0f122f28fc/mobile/android/chrome/content/browser.js#2251 can be removed as well
The block at http://searchfox.org/mozilla-central/rev/7057a51c5cf29b5b115b1db19ace2cfe3fd83a0e/mobile/android/chrome/content/browser.js#2251-2264 should go. Those look like they're not invoked, but please double-check.
Assignee: jh+bugzilla → nobody
Whiteboard: [good first bug][lang=js]
I would like to take up this bug. This would be my first bug so help getting started would be great. I looked at the file, and it seems to me that the add function in the menu needs to be deleted as well as the two lines: options.type = "Menu:Add"; options.id = this._menuId; Please let me know if I am correct and if I can get started.
Hello and welcome, to get started, have a look at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build for how to build Firefox for Android, and http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html / http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html for how to submit patches. As for the code that needs removing, you can use https://dxr.mozilla.org/ or https://searchfox.org/ to search our whole codebase. If you do a search for loadDex (https://dxr.mozilla.org/mozilla-central/search?q=loadDex&redirect=false), you can see that nobody else is calling these two methods, so it is safe to remove them. menu.add on the other hand *is* used by us (see e.g. https://dxr.mozilla.org/mozilla-central/search?q=nativewindow.menu&redirect=false) and this is also what add-ons are using to add additional menu entries, so this shouldn't be removed. If you've got any further questions, feel free to ask them either here, or in #mobile on IRC (https://wiki.mozilla.org/IRC).
Here is the link to my patch: https://reviewboard-hg.mozilla.org/gecko/rev/330ce264b26d
Sorry I did not realize I was supposed to put the bug number in the commit message. I hope you are okay with the patch as is.
I have added another one with the correct info and additional patches to make it complete.
Feel free to scrap my first, less complete patch. I hope this one is right. It has the bug number and correct description to match this bug.
This is the new one: https://reviewboard-hg.mozilla.org/gecko/rev/2e918231be96
This is just to notify you to get rid of my old patch with the missing bug number and incomplete fixes.
Hi, I was wondering if you could please look at my commits so far and tell me what I else is needed to disable addons.
Thank you for the explanation!
Comment on attachment 8873230 [details] Bug 1363843 - Remove Java Addons support from Fennec, Part 2 https://reviewboard.mozilla.org/r/144680/#review148918 Looks fine. One small tip for the future: Don't necessarily just copy the bug title for the commit message. Instead, make it a short description of what your patch is actually doing. In this case it's okay, though, as it's a small patch and the bug title is descriptive enough for our purposes.
Attachment #8873230 - Flags: review?(jh+bugzilla) → review+
I've also started a test run for your patch, you can follow its progress here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c16837badec If everything turns out okay, you can then set the "checkin-needed" keyword on this bug to get this landed. Thanks and feel free to tackle your next bug whenever you like.
Assignee: nobody → dev.varuniyer
Comment on attachment 8873230 [details] Bug 1363843 - Remove Java Addons support from Fennec, Part 2 https://reviewboard.mozilla.org/r/144680/#review149070
Attachment #8873230 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/2f1c4c291038 Remove Java Addons support from Fennec, Part 2 r=JanH
Landed it for you - next time, just edit this bug and add "checkin-needed" in the "Keyword" field in the "Tracking" section. Also, in this case there's no point in giving your own patch a r+.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.