1363914 - Missing tests for netmonitor filter flags

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Matt R [:stylizit] (slow, away until Sep)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.96 Safari/537.36

Steps to reproduce:

We currently have a suite of tests in  devtools/client/netmonitor/test/browser_net_filter-flags.js for : "running", "is", "status-code", "mime-type", "method", "scheme", "regexp" filter flags.

We miss tests for "protocol", "domain", "remote-ip", "has-response-header", "cause", "transferred", "larger-than", "size", "set-cookie-domain", "set-cookie-name", "set-cookie-value" filter flags.




Actual results:

Some filter flags don't have tests


Expected results:

All filters flags should have tests

Comment 1

[Matt R [:stylizit] (slow, away until Sep)]

Also, in devtools/client/netmonitor/test/browser_net_filter-flags.js, I think the "isSizeMatch" function seems slightly wrong as isSizeMatch(0, 0) returns false. 

http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/utils/filter-text-utils.js#215

As other filters depend on this, it probably needs to be addressed before we can add more tests.

Comment 2

[Tim Nguyen :ntim]

The cookie tests are being added in bug 1360473

Comment 3

[Matt R [:stylizit] (slow, away until Sep)]

Thanks, could you also please assign this to me if you're comfortable with it?

Comment 4

[Matt R [:stylizit] (slow, away until Sep)]

Attachment: Bug 1363914 - Added tests for filter flags: protocol, domain, remote-ip, has-response-headers, cause, transferred, larger-than and size;

Review commit: https://reviewboard.mozilla.org/r/142978/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142978/

Comment 5

[Matt R [:stylizit] (slow, away until Sep)]

I added the tests missing for the remaining filter flags:
- Fixed isSizeMatch
- Added a new request using gzip so we can differentiate between "larger-than" and "transferred-larger-than"

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8871709 [details]
Bug 1363914 - Added tests for filter flags: protocol, domain, remote-ip, has-response-headers, cause, transferred, larger-than and size;

https://reviewboard.mozilla.org/r/142978/#review148270

Looks reasonable.

R+ assuming Try is green

Thanks for the patch!

Honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd0112703ea0
Added tests for filter flags: protocol, domain, remote-ip, has-response-headers, cause, transferred, larger-than and size; r=Honza

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd0112703ea0