Closed
Bug 1363940
Opened 7 years ago
Closed 7 years ago
Intermittent text/wordwrap-02.html == text/wordwrap-02-ref.html | image comparison, max difference: 1, number of differing pixels: 1
Categories
(Core :: Layout: Text and Fonts, defect, P3)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: intermittent-bug-filer, Assigned: jfkthame)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other])
Attachments
(1 file)
1.51 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=98119589&repo=mozilla-central https://queue.taskcluster.net/v1/task/I-Q8l_zqS5umJL-22fqOqg/runs/0/artifacts/public/logs/live_backing.log https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/I-Q8l_zqS5umJL-22fqOqg/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Updated•7 years ago
|
Priority: -- → P3
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 21•7 years ago
|
||
this started on oct 2nd as a high frequency failure, I have just kicked off some retriggers to maybe identify the root cause: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=reftest-44&tochange=b00cd35474a0ffa96b76ed255eb35a3763b51be2&fromchange=f1251736514da97cf8065f631f0c93ce5c8695c7&selectedJob=134302667 :jfkthame, this has started (perma?) failing on android in the last 2 days, is this something you can take a look at or recommend disabling?
Flags: needinfo?(jfkthame)
Whiteboard: [stockwell needswork]
Assignee | ||
Comment 22•7 years ago
|
||
I have no idea why this has suddenly become more frequent, but AFAICS (at least in the cases I've looked at) the discrepancy is just a single corner pixel of the textarea's frame; it's nothing to do with the content actually being tested. As such, I would vote for just annotating it as fuzzy and moving on.
Flags: needinfo?(jfkthame)
Assignee | ||
Comment 23•7 years ago
|
||
If you can pinpoint a recent regression (IMO this looks more like a graphics than layout issue, actually), maybe we can do something, but otherwise this is what I'd suggest.
Comment 24•7 years ago
|
||
the retriggers didn't show any patterns/root causes, I would recommend r? for the fuzzy patch.
Assignee | ||
Updated•7 years ago
|
Attachment #8915120 -
Flags: review?(dholbert)
Comment 25•7 years ago
|
||
Bug 1363945 is just the same: upper right pixel, failing frequently on Android beginning around when the changes for bug 1381434 landed. I've ni'd schien in bug 1363945. (But this was a pre-existing problem...fuzzy-if might be the best way forward.)
Comment 26•7 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #25) > upper right pixel Sorry -- upper left pixel.
Assignee | ||
Comment 27•7 years ago
|
||
I guess bug 1381434 is likely to have affected timing of the webfont load used in these tests, and in turn that probably affects (re)painting behavior, e.g. depending whether or not the completion of the font load triggers an additional reflow/paint cycle after the initial page load has happened.
Comment 28•7 years ago
|
||
Comment on attachment 8915120 [details] [diff] [review] Mark testcase as fuzzy on Android due to unreliable corner pixel of the frame Review of attachment 8915120 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8915120 -
Flags: review?(dholbert) → review+
Comment 29•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/b76ca0d42c55
status-firefox57:
--- → fixed
Comment hidden (Intermittent Failures Robot) |
Comment 31•7 years ago
|
||
Pushed by jkew@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/10ca1d0023d7 Mark testcase as fuzzy on Android due to unreliable corner pixel of the frame. r=dholbert
Comment hidden (Intermittent Failures Robot) |
Comment 33•7 years ago
|
||
I assume this is fixed, we haven't merged in a while.
Whiteboard: [stockwell disable-recommended] → [stockwell needswork]
Comment 34•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/10ca1d0023d7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Assignee: nobody → jfkthame
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Whiteboard: [stockwell disable-recommended] → [stockwell fixed:other]
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•