stylo: ASan detected leaks

NEW
Unassigned

Status

()

Core
CSS Parsing and Computation
P1
normal
3 months ago
3 days ago

People

(Reporter: shinglyu, Unassigned, NeedInfo)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 months ago
Created attachment 8866652 [details]
List of "leaks at ..." log entries

Linux64-asan (with stylo enabled) found a lot of leaks in mochitests and reftests.

Step to reproduce:
* Add "--enable-stylo" to asan mozconfigs: [1]
* Push try: "try: -b do -p linux64-asan -u all -t none"

An example push: [2].

I also attached the list of leaking locations, extracted from the logs.

[1] https://hg.mozilla.org/try/rev/47bef5c8de54ee1edac4f6d924550123fe84daba
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=d31cf95b1ac021ba56d010754062a7f3134c7e42
Looks to me like we're leaking servo stylesheets, but not the corresponding gecko data structures.
Priority: -- → P1
Blocks: 1330412
No longer blocks: 1243581
I wonder if we still get these leaks.  Shing, could you do another try run?  If we've still got leaks we should look at them soon.
Flags: needinfo?(shing.lyu)
You need to log in before you can comment on or make changes to this bug.