1364026 - [DateTimePicker] Check if min and max attributes are valid date strings

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, enhancement, P1)

Description

[Scott Wu [:scottwu]]

According to the spec[1], the min and max should be valid date strings, and should be set to empty if they aren't.

Currently, the min and max values are used directly in Date constructor, which is very forgiving and can parse the dates that aren't valid date strings. This causes discrepancy between the input box and the picker.

[1] https://html.spec.whatwg.org/multipage/forms.html#date-state-(type=date)

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1364026 - (Part 1) Expose HTMLInputElement.getMinimum/getMaximum methods via webidl.

Review commit: https://reviewboard.mozilla.org/r/155960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155960/

Comment 2

[Scott Wu [:scottwu]]

Attachment: Bug 1364026 - (Part 2) Check if min and max attributes on input type date are valid date strings.

Review commit: https://reviewboard.mozilla.org/r/155962/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155962/

Comment 3

[Scott Wu [:scottwu]]

Comment on attachment 8885109 [details]
Bug 1364026 - (Part 2) Check if min and max attributes on input type date are valid date strings.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155962/diff/1-2/

Comment 4

[Scott Wu [:scottwu]]

Rather than re-implementing the date validation method, I exposed the cpp method via webidl. Do you think this approach is okay :jessica?

Comment 5

[Jessica Jong [:jessica] (inactive)]

(In reply to Scott Wu [:scottwu] from comment #4)
> Rather than re-implementing the date validation method, I exposed the cpp
> method via webidl. Do you think this approach is okay :jessica?

I think it's okay as long as it's chrome only. You can just use "ChromeOnly", I don't think XBL code needs it right now.
And maybe "GetMinimum/Maximum" would be more useful?

Please remember that changing .webdil requires review from a DOM peer.

Comment 6

[Scott Wu [:scottwu]]

Comment on attachment 8885108 [details]
Bug 1364026 - (Part 1) Expose HTMLInputElement.getMinimum/getMaximum methods via webidl.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155960/diff/1-2/

Comment 7

[Scott Wu [:scottwu]]

Comment on attachment 8885109 [details]
Bug 1364026 - (Part 2) Check if min and max attributes on input type date are valid date strings.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155962/diff/2-3/

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8885109 [details]
Bug 1364026 - (Part 2) Check if min and max attributes on input type date are valid date strings.

https://reviewboard.mozilla.org/r/155962/#review162604

Looks good, thanks!

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8885108 [details]
Bug 1364026 - (Part 1) Expose HTMLInputElement.getMinimum/getMaximum methods via webidl.

https://reviewboard.mozilla.org/r/155960/#review163096

Comment 10

[Scott Wu [:scottwu]]

Thanks :mconley and :smaug! Checking it in.

Comment 11

[Scott Wu [:scottwu]]

Comment on attachment 8885108 [details]
Bug 1364026 - (Part 1) Expose HTMLInputElement.getMinimum/getMaximum methods via webidl.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155960/diff/2-3/

Comment 12

[Scott Wu [:scottwu]]

Comment on attachment 8885109 [details]
Bug 1364026 - (Part 2) Check if min and max attributes on input type date are valid date strings.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155962/diff/3-4/

Comment 13

[Scott Wu [:scottwu]]

(In reply to Scott Wu [:scottwu] from comment #12)
> Comment on attachment 8885109 [details]
> Bug 1364026 - (Part 2) Check if min and max attributes on input type date
> are valid date strings.
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/155962/diff/3-4/

Rebased to central and resolved conflicts.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee20903b5973
(Part 1) Expose HTMLInputElement.getMinimum/getMaximum methods via webidl. r=smaug
https://hg.mozilla.org/integration/autoland/rev/39f99fa53275
(Part 2) Check if min and max attributes on input type date are valid date strings. r=mconley

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ee20903b5973
https://hg.mozilla.org/mozilla-central/rev/39f99fa53275