1364135 - Clean up detection/handling of deleted keyrings

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Ethan Glasser-Camp (:glasserc)]

Bug 1359879 discovered that server-side data was occasionally being deleted for all users due to an embarrassing bug in Kinto. That bug also hastily hacked together a workaround for users who encountered failures as a result of that deletion. However, the patch provided in that bug relies on some behaviors of kinto.js that aren't technically correct -- when syncing with SERVER_WINS, deletion on the server should produce deletion on the client. This was corrected in kinto.js 9.0.0. Update to a new kinto.js and update the logic in storage.sync to be cleaner but still have essentially the same result.

Comment 1

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1364135: Clean up detection/handling of deleted keyrings,

Review commit: https://reviewboard.mozilla.org/r/138446/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/138446/

Comment 2

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dee5691d1635

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 8866861 [details]
Bug 1364135: Clean up detection/handling of deleted keyrings,

https://reviewboard.mozilla.org/r/138446/#review141782

r+ on kinto-offline-client.js purely from an Fx integration perspective (as usual).

Comment 4

[Ethan Glasser-Camp (:glasserc)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3dc3e582c63e

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8866861 [details]
Bug 1364135: Clean up detection/handling of deleted keyrings,

https://reviewboard.mozilla.org/r/138446/#review146618

::: services/common/kinto-offline-client.js:181
(Diff revision 1)
> +      remote,
> +      events,
> +      headers,
> +      retry,
> +      requestMode,
> +      timeout,
> +      ApiClass

If we're keeping these on separate lines, please also keep them sorted. Same for the ones below.

Comment 6

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8866861 [details]
Bug 1364135: Clean up detection/handling of deleted keyrings,

https://reviewboard.mozilla.org/r/138446/#review146618

> If we're keeping these on separate lines, please also keep them sorted. Same for the ones below.

This is compiled output that is vendored so I'm not crazy about it having to conform to Firefox code style. It happens that Mozilla has a substantial investment in that upstream project so I guess I can change it upstream and cut a new release, but I'd say that's outside the scope of this bug. (Doing it properly probably means an eslint rule.)

Comment 7

[Ethan Glasser-Camp (:glasserc)]

Comment on attachment 8866861 [details]
Bug 1364135: Clean up detection/handling of deleted keyrings,

https://reviewboard.mozilla.org/r/138446/#review146618

> This is compiled output that is vendored so I'm not crazy about it having to conform to Firefox code style. It happens that Mozilla has a substantial investment in that upstream project so I guess I can change it upstream and cut a new release, but I'd say that's outside the scope of this bug. (Doing it properly probably means an eslint rule.)

(I spoke about it with :John-Galt on IRC and he said that was fine with him, so I'm marking this as fixed even though it isn't really.)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9494a5b0b185
Clean up detection/handling of deleted keyrings, r=kmag,MattN

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9494a5b0b185