Closed
Bug 1364135
Opened 8 years ago
Closed 8 years ago
Clean up detection/handling of deleted keyrings
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: glasserc, Assigned: glasserc)
References
Details
Attachments
(1 file)
Bug 1359879 discovered that server-side data was occasionally being deleted for all users due to an embarrassing bug in Kinto. That bug also hastily hacked together a workaround for users who encountered failures as a result of that deletion. However, the patch provided in that bug relies on some behaviors of kinto.js that aren't technically correct -- when syncing with SERVER_WINS, deletion on the server should produce deletion on the client. This was corrected in kinto.js 9.0.0. Update to a new kinto.js and update the logic in storage.sync to be cleaner but still have essentially the same result.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8866861 [details]
Bug 1364135: Clean up detection/handling of deleted keyrings,
https://reviewboard.mozilla.org/r/138446/#review141782
r+ on kinto-offline-client.js purely from an Fx integration perspective (as usual).
Attachment #8866861 -
Flags: review?(MattN+bmo) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8866861 [details]
Bug 1364135: Clean up detection/handling of deleted keyrings,
https://reviewboard.mozilla.org/r/138446/#review146618
::: services/common/kinto-offline-client.js:181
(Diff revision 1)
> + remote,
> + events,
> + headers,
> + retry,
> + requestMode,
> + timeout,
> + ApiClass
If we're keeping these on separate lines, please also keep them sorted. Same for the ones below.
Attachment #8866861 -
Flags: review?(kmaglione+bmo) → review+
Assignee | ||
Comment 6•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8866861 [details]
Bug 1364135: Clean up detection/handling of deleted keyrings,
https://reviewboard.mozilla.org/r/138446/#review146618
> If we're keeping these on separate lines, please also keep them sorted. Same for the ones below.
This is compiled output that is vendored so I'm not crazy about it having to conform to Firefox code style. It happens that Mozilla has a substantial investment in that upstream project so I guess I can change it upstream and cut a new release, but I'd say that's outside the scope of this bug. (Doing it properly probably means an eslint rule.)
Assignee | ||
Comment 7•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8866861 [details]
Bug 1364135: Clean up detection/handling of deleted keyrings,
https://reviewboard.mozilla.org/r/138446/#review146618
> This is compiled output that is vendored so I'm not crazy about it having to conform to Firefox code style. It happens that Mozilla has a substantial investment in that upstream project so I guess I can change it upstream and cut a new release, but I'd say that's outside the scope of this bug. (Doing it properly probably means an eslint rule.)
(I spoke about it with :John-Galt on IRC and he said that was fine with him, so I'm marking this as fixed even though it isn't really.)
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Updated•8 years ago
|
Assignee: nobody → eglassercamp
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9494a5b0b185
Clean up detection/handling of deleted keyrings, r=kmag,MattN
Keywords: checkin-needed
![]() |
||
Comment 9•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•