Closed Bug 1364166 Opened 3 years ago Closed 3 years ago

Combined toolbar buttons don't have toolbarbutton-1 class after opening the menu panel

Categories

(Firefox :: Theme, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 55
Iteration:
55.5 - May 15
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- verified

People

(Reporter: johannh, Assigned: johannh)

References

Details

(Keywords: regression, Whiteboard: [photon-structure][p2])

Attachments

(1 file)

This leads to various style regressions on the different platforms.

This regression was on central on May 10th and went into Nightly on May 11th.
Assignee: nobody → jhofmann
Blocks: 1354082
Status: NEW → ASSIGNED
Flags: qe-verify+
Keywords: regression
Priority: -- → P1
Summary: Combined toolbar buttons don't have toolbarbutton-1 class after exiting customize mode → Combined toolbar buttons don't have toolbarbutton-1 class after opening the menu panel
Whiteboard: [photon-structure][p2]
QA Contact: gwimberly
Comment on attachment 8867021 [details]
Bug 1364166 - Only update combined buttons style in the customizableUI panel.

https://reviewboard.mozilla.org/r/138628/#review142080
Attachment #8867021 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dae04df69680
Only update combined buttons style in the customizableUI panel. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/dae04df69680
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Iteration: --- → 55.5 - May 15
Any suggestions for steps to verify this? Thanks.
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Grover Wimberly IV [:Grover-QA] from comment #5)
> Any suggestions for steps to verify this? Thanks.

Yup:

1. open nightly with the photon structure pref turned OFF
2. move the edit and zoom controls to a toolbar using context menus or customize mode
3. restart nightly
4. hover over the edit/zoom controls. You should see hover feedback on those buttons
5. open the main/hamburger menu panel
6. close the panel and hover over the edit/zoom controls again

Before this fix:
no hover feedback

After this fix:
hover feedback!
Flags: needinfo?(gijskruitbosch+bugs)
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Blocks: 1387512
You need to log in before you can comment on or make changes to this bug.