59 bytes, text/x-review-board-request
This leads to various style regressions on the different platforms. This regression was on central on May 10th and went into Nightly on May 11th.
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: -- → P1
Summary: Combined toolbar buttons don't have toolbarbutton-1 class after exiting customize mode → Combined toolbar buttons don't have toolbarbutton-1 class after opening the menu panel
status-firefox54: --- → unaffected
status-firefox55: --- → affected
Comment on attachment 8867021 [details] Bug 1364166 - Only update combined buttons style in the customizableUI panel. https://reviewboard.mozilla.org/r/138628/#review142080
Attachment #8867021 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/dae04df69680 Only update combined buttons style in the customizableUI panel. r=Gijs
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Any suggestions for steps to verify this? Thanks.
(In reply to Grover Wimberly IV [:Grover-QA] from comment #5) > Any suggestions for steps to verify this? Thanks. Yup: 1. open nightly with the photon structure pref turned OFF 2. move the edit and zoom controls to a toolbar using context menus or customize mode 3. restart nightly 4. hover over the edit/zoom controls. You should see hover feedback on those buttons 5. open the main/hamburger menu panel 6. close the panel and hover over the edit/zoom controls again Before this fix: no hover feedback After this fix: hover feedback!
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
status-firefox53: --- → unaffected
status-firefox-esr52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.