Closed
Bug 1364194
Opened 8 years ago
Closed 8 years ago
Dynamic toolbar snapshot is not updated when hidden and device is rotated
Categories
(Firefox for Android Graveyard :: Toolbar, defect, P2)
Tracking
(firefox53 unaffected, firefox54 unaffected, firefox55 fixed)
RESOLVED
FIXED
Firefox 55
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | unaffected |
| firefox54 | --- | unaffected |
| firefox55 | --- | fixed |
People
(Reporter: rbarker, Assigned: rbarker)
References
Details
(Keywords: regression)
Attachments
(1 file)
Steps to reproduce:
1) hide toolbar
2) rotate device
3) make toolbar partial visible with a drag
Expect result:
The toolbar looks correct
Actual result:
The toolbar is either stretched or squashed.
Problem:
When the device is rotated with the toolbar hidden, the static snapshot is not getting updated. The animator needs to request a snapshot update if the page width changes and the toolbar is hidden.
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → rbarker
|
|
Assignee | |
Updated•8 years ago
|
Blocks: dynamic-toolbar-3
|
|
Assignee | |
Updated•8 years ago
|
Summary: Dynamic toolbar snap shot is not updated when hidden and device is rotated → Dynamic toolbar snapshot is not updated when hidden and device is rotated
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Updated•8 years ago
|
status-firefox53:
--- → unaffected
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
Keywords: regression
Priority: -- → P2
Hardware: Unspecified → All
Version: unspecified → 55 Branch
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8866938 [details]
Bug 1364194 - Refresh static toolbar snapshot when page width changes
https://reviewboard.mozilla.org/r/138546/#review142140
r+ on the C++ change.
Attachment #8866938 -
Flags: review?(botond) → review+
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8866938 [details]
Bug 1364194 - Refresh static toolbar snapshot when page width changes
https://reviewboard.mozilla.org/r/138546/#review142262
Attachment #8866938 -
Flags: review?(nchen) → review+
Pushed by rbarker@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/250d3d370798
Refresh static toolbar snapshot when page width changes r=botond,jchen
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•